Skip to content
This repository has been archived by the owner on Jun 4, 2019. It is now read-only.

Trying to build on macOS 10.12 #145

Closed
smithrb opened this issue Aug 2, 2016 · 2 comments
Closed

Trying to build on macOS 10.12 #145

smithrb opened this issue Aug 2, 2016 · 2 comments

Comments

@smithrb
Copy link

smithrb commented Aug 2, 2016

Receiving the following during make:

File "/Users/razbear/Documents/dev/pfff/lang_nw/parsing/lexer_nw.mll", line 140, characters 15-21:
Warning 52: the argument of this constructor should not be matched against a
constant pattern; the actual value of the argument could change
in the future.

Any ideas?

@aryx
Copy link
Contributor

aryx commented Aug 3, 2016

It's a new warning of a recent version of ocaml probably.
It just points out bad practice. You can replace Failure("hd") by Failure(_)
and the warning should disappear.

aryx added a commit that referenced this issue Aug 3, 2016
@aryx aryx closed this as completed Aug 3, 2016
@smithrb
Copy link
Author

smithrb commented Aug 3, 2016

Thanks - that fixed it. Also had _ascii appends to string conversions...

Clean build finally, looking for examples now.

Thanks!

On Aug 2, 2016, at 9:44 PM, Yoann Padioleau notifications@github.com wrote:

It's a new warning of a recent version of ocaml probably.
It just points out bad practice. You can replace Failure("hd") by Failure(_)
and the warning should disappear.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #145 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AGO-tgHxGgjibkgKvi0mGBxUMkAuo0vdks5qb_J1gaJpZM4JbKgL.

aryx added a commit that referenced this issue Aug 11, 2016
It is causing compilation error with ocaml 4.02.3 apparently.
Should fix issue #133 and issue #145
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants