fix data migration issues when migrating from really old databases

[WattsInABox]

We had an issue when migrating our 8-month old database. Apparently, there were some revisions that had reviewers that were missing the src_type (or type) in their data column. These two guard statements fixed that issue for us.

[epriestley]

Which migration did this fix, specifically? I'd rather fix the migration than adjust the EdgeEditor, if possible. Do you have the original error/trace?

[WattsInABox]

I would, too, but I'm not a PHP guy anymore so it was a little difficult finding the fix. 20131004.dxreviewers.php. I didn't save off the trace, but it was on line 192 of PhabricatorEdgeConfig.php:

if (!$class) {
      throw new Exception(
        "Edges are not available for objects of type '{$phid_type}'!");
    }

and $phid_type ended up being equal to '????'

[epriestley]

Thanks! I'll see if I can come up with a more surgical fix. We're in the middle of some other stuff so it might take me a couple of days to get to, but you're not blocked on this anymore, right? I can look at it sooner if you're still having issues, but it sounds like things worked after your patch?

[WattsInABox]

Oh yeah, we're good. I just wanted to contribute it back and make you aware so other people don't have the same issue.

[epriestley]

https://secure.phabricator.com/D8837

[WattsInABox]

thanks, btw! I know this was forever ago.