Substitute v8-profiler with v8-profiler-node8
#2525
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
changed the title
v8-profiler with v8-profiler-node8v8-profiler with v8-profiler-node8
This commit addresses issue #2520. In brief, `v8-profiler` fails to build on recent node versions.
There was a problem hiding this comment.
LGTM. Turns out one needs an older version of Chome to process CPU profiles: https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Mac/464636/
There was a problem hiding this comment.
NTillmann is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
NTillmann has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This commit addresses issue #2520. In brief,
v8-profilerfails to build on recent node versions.