Enable block guard for promises

Summary:
Changelog: Resolve memory leak in promises on iOS

Enable block guard for promises

Reviewed By: RSNara

Differential Revision: D28252977

fbshipit-source-id: 052fefca0a6ac54597a46922fc467a2a39f7976f

Author: sammy-SC

React/Base/RCTBridge.h

@@ -164,6 +164,10 @@ RCT_EXTERN void RCTEnableTurboModuleSharedMutexInit(BOOL enabled);
 RCT_EXTERN BOOL RCTTurboModuleBlockGuardEnabled(void);
 RCT_EXTERN void RCTEnableTurboModuleBlockGuard(BOOL enabled);
 
+// Turn on TurboModule block guard for promises.
+RCT_EXTERN BOOL RCTTurboModulePromisesBlockGuardEnabled(void);
+RCT_EXTERN void RCTEnableTurboModulePromisesBlockGuard(BOOL enabled);
+
 /**
  * Async batched bridge used to communicate with the JavaScript application.
  */

React/Base/RCTBridge.m

@@ -149,6 +149,17 @@ void RCTEnableTurboModuleBlockGuard(BOOL enabled)
   turboModuleBlockGuardEnabled = enabled;
 }
 
+static BOOL turboModulePromisesBlockGuardEnabled = NO;
+BOOL RCTTurboModulePromisesBlockGuardEnabled(void)
+{
+  return turboModulePromisesBlockGuardEnabled;
+}
+
+void RCTEnableTurboModulePromisesBlockGuard(BOOL enabled)
+{
+  turboModulePromisesBlockGuardEnabled = enabled;
+}
+
 @interface RCTBridge () <RCTReloadListener>
 @end
 

ReactCommon/react/nativemodule/core/platform/ios/RCTTurboModule.mm

@@ -254,6 +254,21 @@ static int32_t getUniqueId()
         __block BOOL resolveWasCalled = NO;
         __block BOOL rejectWasCalled = NO;
 
+        RCTBlockGuard *blockGuard;
+        if (RCTTurboModulePromisesBlockGuardEnabled()) {
+          blockGuard = [[RCTBlockGuard alloc] initWithCleanup:^() {
+            auto strongResolveWrapper = weakResolveWrapper.lock();
+            if (strongResolveWrapper) {
+              strongResolveWrapper->destroy();
+            }
+
+            auto strongRejectWrapper = weakRejectWrapper.lock();
+            if (strongRejectWrapper) {
+              strongRejectWrapper->destroy();
+            }
+          }];
+        }
+
         RCTPromiseResolveBlock resolveBlock = ^(id result) {
           if (rejectWasCalled) {
             RCTLogError(@"%s: Tried to resolve a promise after it's already been rejected.", moduleMethod.c_str());
@@ -271,7 +286,7 @@ static int32_t getUniqueId()
             return;
           }
 
-          strongResolveWrapper->jsInvoker().invokeAsync([weakResolveWrapper, weakRejectWrapper, result]() {
+          strongResolveWrapper->jsInvoker().invokeAsync([weakResolveWrapper, weakRejectWrapper, result, blockGuard]() {
             auto strongResolveWrapper2 = weakResolveWrapper.lock();
             auto strongRejectWrapper2 = weakRejectWrapper.lock();
             if (!strongResolveWrapper2 || !strongRejectWrapper2) {
@@ -284,6 +299,7 @@ static int32_t getUniqueId()
 
             strongResolveWrapper2->destroy();
             strongRejectWrapper2->destroy();
+            (void)blockGuard;
           });
 
           resolveWasCalled = YES;
@@ -307,7 +323,7 @@ static int32_t getUniqueId()
           }
 
           NSDictionary *jsError = RCTJSErrorFromCodeMessageAndNSError(code, message, error);
-          strongRejectWrapper->jsInvoker().invokeAsync([weakResolveWrapper, weakRejectWrapper, jsError]() {
+          strongRejectWrapper->jsInvoker().invokeAsync([weakResolveWrapper, weakRejectWrapper, jsError, blockGuard]() {
             auto strongResolveWrapper2 = weakResolveWrapper.lock();
             auto strongRejectWrapper2 = weakRejectWrapper.lock();
             if (!strongResolveWrapper2 || !strongRejectWrapper2) {
@@ -320,6 +336,7 @@ static int32_t getUniqueId()
 
             strongResolveWrapper2->destroy();
             strongRejectWrapper2->destroy();
+            (void)blockGuard;
           });
 
           rejectWasCalled = YES;