Skip to content

Commit 2789ba0

Browse files
sherginfacebook-github-bot
authored andcommitted
zIndex prop was removed from RCTShadowView
Summary: This was leftovers from old implementation of zIndex feature. Janic janicduplessis refactored this and moved all logic to UIView layer, so we don't need this prop anymore in shadow realm. More info: #14011 Reviewed By: mmmulani Differential Revision: D6574414 fbshipit-source-id: 2cae19350765689784d7884ed875878d39b4e3f1
1 parent 4803419 commit 2789ba0

File tree

3 files changed

+0
-16
lines changed

3 files changed

+0
-16
lines changed

React/Views/RCTShadowView.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,11 +170,6 @@ typedef void (^RCTApplierBlock)(NSDictionary<NSNumber *, UIView *> *viewRegistry
170170

171171
@property (nonatomic, assign) float aspectRatio;
172172

173-
/**
174-
* z-index, used to override sibling order in the view
175-
*/
176-
@property (nonatomic, assign) NSInteger zIndex;
177-
178173
/**
179174
* Interface direction (LTR or RTL)
180175
*/

React/Views/RCTShadowView.m

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -792,16 +792,6 @@ - (void)setBackgroundColor:(UIColor *)color
792792
[self dirtyPropagation];
793793
}
794794

795-
- (void)setZIndex:(NSInteger)zIndex
796-
{
797-
_zIndex = zIndex;
798-
if (_superview) {
799-
// Changing zIndex means the subview order of the parent needs updating
800-
_superview->_didUpdateSubviews = YES;
801-
[_superview dirtyPropagation];
802-
}
803-
}
804-
805795
- (void)didUpdateReactSubviews
806796
{
807797
// Does nothing by default

React/Views/RCTViewManager.m

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,6 @@ - (RCTViewManagerUIBlock)uiBlockToAmendWithShadowViewRegistry:(__unused NSDictio
336336

337337
RCT_EXPORT_SHADOW_PROPERTY(onLayout, RCTDirectEventBlock)
338338

339-
RCT_EXPORT_SHADOW_PROPERTY(zIndex, NSInteger)
340339
RCT_EXPORT_SHADOW_PROPERTY(direction, YGDirection)
341340

342341
@end

0 commit comments

Comments
 (0)