Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Crash if WebView is disabled (#34483)
Summary: When the webview is updated by play store, all apps that has loaded webview gets killed. For background see https://issuetracker.google.com/issues/228611949?pli=1 We have a long-running app and don't want this to happen and while we are not using webview anywhere, we are using websockets that loads it for reading cookies, however we are not using cookies to authenticate the websocket and thus want to disable the webview to avoid loading it unnecessarily and then getting killed unnecessarily. The webview has support for beeing disabled https://developer.android.com/reference/android/webkit/WebView#disableWebView() however as-is this crashes React Native. It seems to me like this case is very similar to not having web view installed and should be handled in the same way. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Fixed] - Avoid crash in ForwardingCookieHandler if webview is disabled Pull Request resolved: #34483 Test Plan: Add `WebView.disableWebView();` as the first line in `MainActivity.onCreate`. Reviewed By: christophpurrer Differential Revision: D38981827 Pulled By: cipolleschi fbshipit-source-id: 335a8420568ad0c80b834ae8a3b164e55ebe26f3
- Loading branch information
5451cd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ge this 100x times on 0.70
5451cd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hasn't been released yet. Will land in 0.71