Skip to content
Permalink
Browse files

ReactSlider extends AppCompatSeekBar (#23304)

Summary:
Google recommends to use AppCompat widgets, and this PR changes ReactSlider to extend AppCompatSeekBar.

[Android] [Changed] - ReactSlider extends AppCompatSeekBar
Pull Request resolved: #23304

Differential Revision: D13973636

Pulled By: cpojer

fbshipit-source-id: 9aa160b186fcea593224c5760a2de0fc3a2b6f85
  • Loading branch information...
dulmandakh authored and facebook-github-bot committed Feb 6, 2019
1 parent 185320d commit 833429dd633b33fff71224a7ce663b60681a7f81
@@ -3,14 +3,13 @@ load("//tools/build_defs/oss:rn_defs.bzl", "YOGA_TARGET", "react_native_dep", "r
rn_android_library(
name = "slider",
srcs = glob(["*.java"]),
provided_deps = [
react_native_dep("third-party/android/support/v7/appcompat-orig:appcompat"),
],
visibility = [
"PUBLIC",
],
deps = [
YOGA_TARGET,
react_native_dep("third-party/android/support/v7/appcompat-orig:appcompat"),
react_native_dep("third-party/android/support/v4:lib-support-v4"),
react_native_dep("third-party/java/jsr-305:jsr-305"),
react_native_target("java/com/facebook/react/bridge:bridge"),
react_native_target("java/com/facebook/react/common:common"),
@@ -8,8 +8,8 @@

import android.content.Context;
import android.os.Build;
import android.support.v7.widget.AppCompatSeekBar;
import android.util.AttributeSet;
import android.widget.SeekBar;
import javax.annotation.Nullable;

/**
@@ -20,7 +20,7 @@
*
* <p>Note that the slider is _not_ a controlled component (setValue isn't called during dragging).
*/
public class ReactSlider extends SeekBar {
public class ReactSlider extends AppCompatSeekBar {

/**
* If step is 0 (unset) we default to this total number of steps. Don't use 100 which leads to
@@ -20,7 +20,6 @@ rn_android_library(
],
exported_deps = [
":classes-for-react-native",
react_native_dep("third-party/android/support-annotations:android-support-annotations"),
],
)

0 comments on commit 833429d

Please sign in to comment.
You can’t perform that action at this time.