Remove shared responsibility between LogBox and ExceptionsManager native module

Summary:
## Context
Right now we are using both LogBox and ExceptionsManager native module to report JS errors in ExceptionsManager.js, from below code we can tell they have some overlapping - when ```__DEV__ === true``` both could report the error.

https://www.internalfb.com/code/fbsource/[5fb44bc926de87e62e6e538082496f22017698eb]/xplat/js/react-native-github/Libraries/Core/ExceptionsManager.js?lines=109-141

## Changes
In this diff overlapping is removed: in ```ExceptionsManager.js``` LogBox will be responsible for showing the error with dialog when ```__DEV__ === true```, when it's prod we'll use ExceptionsManager native module to report the error. As a result LogBox and ExceptionsManager native module don't share responsibilities any more.

Changelog:
[General][Changed] - Remove shared responsibility between LogBox and ExceptionsManager native module

Reviewed By: philIip

Differential Revision: D30942433

fbshipit-source-id: 8fceaaa431e5a460c0ccd151fe9831dcccbcf237

Author: luluwu2032

Libraries/Core/ExceptionsManager.js

@@ -56,94 +56,57 @@ function reportException(
   isFatal: boolean,
   reportToConsole: boolean, // only true when coming from handleException; the error has not yet been logged
 ) {
-  const NativeExceptionsManager = require('./NativeExceptionsManager').default;
-  if (NativeExceptionsManager) {
-    const parseErrorStack = require('./Devtools/parseErrorStack');
-    const stack = parseErrorStack(e?.stack);
-    const currentExceptionID = ++exceptionID;
-    const originalMessage = e.message || '';
-    let message = originalMessage;
-    if (e.componentStack != null) {
-      message += `\n\nThis error is located at:${e.componentStack}`;
-    }
-    const namePrefix = e.name == null || e.name === '' ? '' : `${e.name}: `;
-
-    if (!message.startsWith(namePrefix)) {
-      message = namePrefix + message;
-    }
-
-    message =
-      e.jsEngine == null ? message : `${message}, js engine: ${e.jsEngine}`;
+  const parseErrorStack = require('./Devtools/parseErrorStack');
+  const stack = parseErrorStack(e?.stack);
+  const currentExceptionID = ++exceptionID;
+  const originalMessage = e.message || '';
+  let message = originalMessage;
+  if (e.componentStack != null) {
+    message += `\n\nThis error is located at:${e.componentStack}`;
+  }
+  const namePrefix = e.name == null || e.name === '' ? '' : `${e.name}: `;
 
-    const isHandledByLogBox =
-      e.forceRedbox !== true &&
-      global.RN$Bridgeless !== true &&
-      !global.RN$Express;
+  if (!message.startsWith(namePrefix)) {
+    message = namePrefix + message;
+  }
 
-    const data = preprocessException({
-      message,
-      originalMessage: message === originalMessage ? null : originalMessage,
-      name: e.name == null || e.name === '' ? null : e.name,
-      componentStack:
-        typeof e.componentStack === 'string' ? e.componentStack : null,
-      stack,
-      id: currentExceptionID,
-      isFatal,
-      extraData: {
-        jsEngine: e.jsEngine,
-        rawStack: e.stack,
+  message =
+    e.jsEngine == null ? message : `${message}, js engine: ${e.jsEngine}`;
+
+  const data = preprocessException({
+    message,
+    originalMessage: message === originalMessage ? null : originalMessage,
+    name: e.name == null || e.name === '' ? null : e.name,
+    componentStack:
+      typeof e.componentStack === 'string' ? e.componentStack : null,
+    stack,
+    id: currentExceptionID,
+    isFatal,
+    extraData: {
+      jsEngine: e.jsEngine,
+      rawStack: e.stack,
+    },
+  });
+
+  if (reportToConsole) {
+    // we feed back into console.error, to make sure any methods that are
+    // monkey patched on top of console.error are called when coming from
+    // handleException
+    console.error(data.message);
+  }
 
-        // Hack to hide native redboxes when in the LogBox experiment.
-        // This is intentionally untyped and stuffed here, because it is temporary.
-        suppressRedBox: isHandledByLogBox,
-      },
+  if (__DEV__) {
+    const LogBox = require('../LogBox/LogBox');
+    LogBox.addException({
+      ...data,
+      isComponentError: !!e.isComponentError,
     });
-
-    if (reportToConsole) {
-      // we feed back into console.error, to make sure any methods that are
-      // monkey patched on top of console.error are called when coming from
-      // handleException
-      console.error(data.message);
-    }
-
-    if (__DEV__ && isHandledByLogBox) {
-      const LogBox = require('../LogBox/LogBox');
-      LogBox.addException({
-        ...data,
-        isComponentError: !!e.isComponentError,
-      });
-    }
-
-    if (isFatal || e.type !== 'warn') {
+  } else if (isFatal || e.type !== 'warn') {
+    const NativeExceptionsManager = require('./NativeExceptionsManager')
+      .default;
+    if (NativeExceptionsManager) {
       NativeExceptionsManager.reportException(data);
-
-      if (__DEV__ && !global.RN$Express) {
-        if (e.preventSymbolication === true) {
-          return;
-        }
-        const symbolicateStackTrace = require('./Devtools/symbolicateStackTrace');
-        symbolicateStackTrace(stack)
-          .then(({stack: prettyStack}) => {
-            if (prettyStack) {
-              NativeExceptionsManager.updateExceptionMessage(
-                data.message,
-                prettyStack,
-                currentExceptionID,
-              );
-            } else {
-              throw new Error('The stack is null');
-            }
-          })
-          .catch(error => {
-            console.log('Unable to symbolicate stack trace: ' + error.message);
-          });
-      }
     }
-  } else if (reportToConsole) {
-    // we feed back into console.error, to make sure any methods that are
-    // monkey patched on top of console.error are called when coming from
-    // handleException
-    console.error(e);
   }
 }
 

Libraries/Core/ExtendedError.js

@@ -12,7 +12,6 @@ export type ExtendedError = Error & {
   jsEngine?: string,
   preventSymbolication?: boolean,
   componentStack?: string,
-  forceRedbox?: boolean,
   isComponentError?: boolean,
   type?: string,
   ...