Rename RuntimeScheduler::callImmediates to RuntimeScheduelr::callExpiredTasks

Summary:
changelog: [internal]

Rename method so it does not collide with immediates that already exist in React Native.

Reviewed By: javache

Differential Revision: D34041418

fbshipit-source-id: 0ae75b683983c3be50320b195a7068d7178b0ed8

Author: sammy-SC

ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler.cpp

@@ -92,7 +92,7 @@ void RuntimeScheduler::executeNowOnTheSameThread(
   scheduleWorkLoopIfNecessary();
 }
 
-void RuntimeScheduler::callImmediates(jsi::Runtime &runtime) {
+void RuntimeScheduler::callExpiredTasks(jsi::Runtime &runtime) {
   auto previousPriority = currentPriority_;
   try {
     while (!taskQueue_.empty()) {

ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler.h

@@ -97,15 +97,14 @@ class RuntimeScheduler final {
   RuntimeSchedulerTimePoint now() const noexcept;
 
   /*
-   * Immediate is a task that is expired and should have been already executed
-   * or has priority set to Immediate. Designed to be called in the event
-   * pipeline after an event is dispatched to React. React may schedule events
-   * with immediate priority which need to be handled before the next event is
-   * sent to React.
+   * Expired task is a task that should have been already executed. Designed to
+   * be called in the event pipeline after an event is dispatched to React.
+   * React may schedule events with immediate priority which need to be handled
+   * before the next event is sent to React.
    *
    * Thread synchronization must be enforced externally.
    */
-  void callImmediates(jsi::Runtime &runtime);
+  void callExpiredTasks(jsi::Runtime &runtime);
   void setEnableYielding(bool enableYielding);
 
  private:

ReactCommon/react/renderer/runtimescheduler/tests/RuntimeSchedulerTest.cpp

@@ -532,7 +532,7 @@ TEST_F(RuntimeSchedulerTest, sameThreadTaskCreatesImmediatePriorityTask) {
           runtimeScheduler_->scheduleTask(
               SchedulerPriority::ImmediatePriority, std::move(callback));
 
-          runtimeScheduler_->callImmediates(runtime);
+          runtimeScheduler_->callExpiredTasks(runtime);
         });
   });
 
@@ -569,7 +569,7 @@ TEST_F(RuntimeSchedulerTest, sameThreadTaskCreatesLowPriorityTask) {
 
           runtimeScheduler_->scheduleTask(
               SchedulerPriority::LowPriority, std::move(callback));
-          runtimeScheduler_->callImmediates(runtime);
+          runtimeScheduler_->callExpiredTasks(runtime);
 
           EXPECT_FALSE(didRunSubsequentTask);
         });

ReactCommon/react/renderer/scheduler/Scheduler.cpp

@@ -79,7 +79,7 @@ Scheduler::Scheduler(
         },
         runtime);
     if (runtimeScheduler) {
-      runtimeScheduler->callImmediates(runtime);
+      runtimeScheduler->callExpiredTasks(runtime);
     }
   };