Skip to content

Commit ead19e1

Browse files
hramosfacebook-github-bot
authored andcommitted
Use Fabric by default in RNTester
Summary: It is no longer necessary to specify USE_FABRIC=1 when running `pod install` in order to enable Fabric in RNTester. Changelog: [INTERNAL] Reviewed By: fkgozali Differential Revision: D30977549 fbshipit-source-id: fccc3e433041a710b02ddc516cdff07ce7af2409
1 parent e6fcbc5 commit ead19e1

File tree

3 files changed

+7
-16
lines changed

3 files changed

+7
-16
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ jobs:
404404
steps:
405405
- run:
406406
name: Generate RNTesterPods Workspace
407-
command: cd packages/rn-tester && USE_FABRIC=1 bundle exec pod install --verbose
407+
command: cd packages/rn-tester && bundle exec pod install --verbose
408408

409409
# -------------------------
410410
# Runs iOS unit tests

packages/rn-tester/Podfile

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,8 @@ end
1717
def pods()
1818
project 'RNTesterPods.xcodeproj'
1919

20-
fabric_enabled = false
21-
22-
# To use fabric: set the environment variable `USE_FABRIC` to 1, like below
23-
# $ USE_FABRIC=1 bundle exec pod install
24-
# or
25-
# $ export USE_FABRIC=1
26-
# $ bundle exec pod install
27-
if ENV['USE_FABRIC'] == '1'
28-
puts "Building RNTester with Fabric enabled."
29-
fabric_enabled = true
30-
end
20+
puts "Building RNTester with Fabric enabled."
21+
fabric_enabled = true
3122

3223
prefix_path = "../.."
3324
use_react_native!(path: prefix_path, fabric_enabled: fabric_enabled, hermes_enabled: ENV['USE_HERMES'] == '1')

packages/rn-tester/Podfile.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -872,7 +872,7 @@ SPEC CHECKSUMS:
872872
CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99
873873
DoubleConversion: 831926d9b8bf8166fd87886c4abab286c2422662
874874
FBLazyVector: b81a2b70c72d8b0aefb652cea22c11e9ffd02949
875-
FBReactNativeSpec: 55e1b4e2c593197159844fc5c7f88e68e8cb9980
875+
FBReactNativeSpec: dc003b18677e439a47f8161f18a7e70b8eb7ff63
876876
Flipper: 30e8eeeed6abdc98edaf32af0cda2f198be4b733
877877
Flipper-Boost-iOSX: fd1e2b8cbef7e662a122412d7ac5f5bea715403c
878878
Flipper-DoubleConversion: 57ffbe81ef95306cc9e69c4aa3aeeeeb58a6a28c
@@ -894,7 +894,7 @@ SPEC CHECKSUMS:
894894
React-Core: 15d3fbb3cc863fa9990cc14c303a021cc66892a5
895895
React-CoreModules: 5ee1ed4f8b7f8bdbd45ed155a15c601dca9c73dd
896896
React-cxxreact: 2fe718ab7094db2941ddaf35b2a44b8b57a7cece
897-
React-Fabric: 7641eab239c5fc5669ef22ea08cf383f9066fdcb
897+
React-Fabric: e4ee60d4d30f55068117953ffc4edb04c3175a15
898898
React-graphics: db797c4609216593a1a12d1661716898d303900f
899899
React-jsi: 7cc3d3691803478047e7d2c8eb5d4c2f9c6d2922
900900
React-jsiexecutor: 02ed9d4a28a8acf44788b4697e13c4aadc42cf72
@@ -915,10 +915,10 @@ SPEC CHECKSUMS:
915915
React-RCTVibration: 1a58f6ab1ae5fad004119979b676cb5e912f2e44
916916
React-runtimeexecutor: 4b0c6eb341c7d3ceb5e2385cb0fdb9bf701024f3
917917
ReactCommon: 632474905edd9a20ec4f4084142ff4b4a4f3fd8b
918-
ScreenshotManager: a23f618c2a205e3087f29b05154a7c3d6e515d8a
918+
ScreenshotManager: ba35548b279a0ec9ea99b25f4e8cbb26164d2ac4
919919
Yoga: c0d06f5380d34e939f55420669a60fe08b79bd75
920920
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a
921921

922-
PODFILE CHECKSUM: 5cc47caddf8a8bf3fe9ea873886352846aee027a
922+
PODFILE CHECKSUM: 21be0a8894b752aaab399f9d4075cf41baf345f3
923923

924924
COCOAPODS: 1.10.1

0 commit comments

Comments
 (0)