Enable modernize-avoid-c-arrays in clang tidy

Summary:
changelog: [internal]

In an effort to make our codebase more approachable, I'm enabling more clang-tidy rules.

Read more about modernize-avoid-c-arrays in https://clang.llvm.org/extra/clang-tidy/checks/modernize-avoid-c-arrays.html

Reviewed By: ShikaSD

Differential Revision: D33187162

fbshipit-source-id: c6b3888f67d095274bb492a01132985ae506c0d5

Author: sammy-SC

ReactCommon/react/renderer/.clang-tidy

@@ -3,5 +3,6 @@ InheritParentConfig: true
 Checks: '>
 clang-diagnostic-*,
 modernize-avoid-bind,
+modernize-avoid-c-arrays,
 '
 ...

ReactCommon/react/renderer/core/RawProps.cpp

@@ -8,6 +8,7 @@
 #include "RawProps.h"
 
 #include <react/debug/react_native_assert.h>
+#include <react/renderer/core/RawPropsKey.h>
 #include <react/renderer/core/RawPropsParser.h>
 
 namespace facebook {

ReactCommon/react/renderer/core/RawProps.h

@@ -17,7 +17,6 @@
 #include <jsi/JSIDynamic.h>
 #include <jsi/jsi.h>
 #include <react/renderer/core/PropsParserContext.h>
-#include <react/renderer/core/RawPropsKey.h>
 #include <react/renderer/core/RawPropsPrimitives.h>
 #include <react/renderer/core/RawValue.h>
 #include <vector>

ReactCommon/react/renderer/core/RawPropsKey.cpp

@@ -7,6 +7,7 @@
 
 #include "RawPropsKey.h"
 
+#include <array>
 #include <cassert>
 #include <cstring>
 
@@ -44,11 +45,11 @@ void RawPropsKey::render(char *buffer, RawPropsPropNameLength *length)
 }
 
 RawPropsKey::operator std::string() const noexcept {
-  char buffer[kPropNameLengthHardCap];
+  auto buffer = std::array<char, kPropNameLengthHardCap>();
   RawPropsPropNameLength length = 0;
-  render(buffer, &length);
+  render(buffer.data(), &length);
   react_native_assert(length < kPropNameLengthHardCap);
-  return std::string{buffer, length};
+  return std::string{buffer.data(), length};
 }
 
 static bool areFieldsEqual(char const *lhs, char const *rhs) {