-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update new project template to metro-react-native-babel-preset #20327
Comments
So this means that |
@jamsch Yes it is exactly the same, it was just moved to the metro repo and published under acnew name. |
Yes, I guess this needs to be done before 0.57.0 is released (the first RC will be cut today). As a side-change to this it would be useful to migrate the
|
Let's check this issue once we release RC, we can test the full workflow and see where the references to old babel plugin are and how that affects the project itself. |
@grabbou It should still work with the old plugin as long as there are no significant changes to it. But yeah, we should try to update it before the next release just in case. |
It has been, via this #20653 (linked above) |
The babel plugin was recently moved to the metro repo and published under
metro-react-native-babel-preset
. We need to make sure to update all references to the old babel plugin as it will no longer be updated. I think the main thing that needs updating is the new project template.babelrc
(https://github.com/facebook/react-native/tree/master/local-cli/templates/HelloWorld) andpackage.json
(https://github.com/facebook/react-native/blob/master/local-cli/init/init.js#L102).Note that it it needs to be set as
module:metro-react-native-babel-preset
in.babelrc
since it does not respect the standard babel preset naming (maybe we could fix that also).We also need to communicate this properly in the release notes for existing apps.
The text was updated successfully, but these errors were encountered: