Fix iOS Picker Item Colors #11260
Closed
Fix iOS Picker Item Colors #11260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @spicyj and @adierkens to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
brentvatne
reviewed
Dec 2, 2016
| items.push({ | ||
| value: child.props.value, | ||
| label: child.props.label, | ||
| textColor: processColor(child.props.color)}); |
There was a problem hiding this comment.
style nit: }); should be on a newline, indented to the same level as items
janicduplessis
suggested changes
Dec 2, 2016
| @@ -86,7 +86,13 @@ - (UIView *)pickerView:(UIPickerView *)pickerView | |||
| } | |||
|
|
|||
| label.font = _font; | |||
| label.textColor = _color; | |||
|
|
|||
| if ([_items[row] objectForKey:@"textColor"] == nil) { | |||
There was a problem hiding this comment.
I think we can simplify this a bit with by using the ?: operator.
label.textColor = [RCTConvert UIColor:_items[row][@"textColor"]] ?: _color;
janicduplessis
added
GH Review: needs-revision
Platform: iOS
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
janicduplessis
approved these changes
Dec 3, 2016
|
@facebook-github-bot shipit |
robclouth
pushed a commit
to robclouth/react-native
that referenced
this pull request
Dec 7, 2016
Summary: I want to resolve facebook#11170 by passing the `color` prop from `PickerIOS.Item` to its implementation. In `RCTPicker.m`, the label.textColor was already being set and used, but there was nothing referencing the past prop. I passed the prop to the implementation, checked if it exists, and if not, set the default color, like before. I visually tested the **Colorful Pickers** example in UIExplorer. Those picker `Item`s pass in a `color` prop.  The basic picker does not pass the color prop to the picker `Item`, and there are no errors. Basic functionality is still in tact:  Closes facebook#11260 Differential Revision: D4272370 fbshipit-source-id: 5fa33c40526dda59ca2ab527c31351bcd27e5cf3
mkonicek
pushed a commit
that referenced
this pull request
Dec 12, 2016
Summary: I want to resolve #11170 by passing the `color` prop from `PickerIOS.Item` to its implementation. In `RCTPicker.m`, the label.textColor was already being set and used, but there was nothing referencing the past prop. I passed the prop to the implementation, checked if it exists, and if not, set the default color, like before. I visually tested the **Colorful Pickers** example in UIExplorer. Those picker `Item`s pass in a `color` prop.  The basic picker does not pass the color prop to the picker `Item`, and there are no errors. Basic functionality is still in tact:  Closes #11260 Differential Revision: D4272370 fbshipit-source-id: 5fa33c40526dda59ca2ab527c31351bcd27e5cf3
DanielMSchmidt
pushed a commit
to DanielMSchmidt/react-native
that referenced
this pull request
Jan 4, 2017
Summary: I want to resolve facebook#11170 by passing the `color` prop from `PickerIOS.Item` to its implementation. In `RCTPicker.m`, the label.textColor was already being set and used, but there was nothing referencing the past prop. I passed the prop to the implementation, checked if it exists, and if not, set the default color, like before. I visually tested the **Colorful Pickers** example in UIExplorer. Those picker `Item`s pass in a `color` prop.  The basic picker does not pass the color prop to the picker `Item`, and there are no errors. Basic functionality is still in tact:  Closes facebook#11260 Differential Revision: D4272370 fbshipit-source-id: 5fa33c40526dda59ca2ab527c31351bcd27e5cf3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to resolve #11170 by passing the
colorprop fromPickerIOS.Itemto its implementation.In
RCTPicker.m, the label.textColor was already being set and used, but there was nothing referencing the past prop. I passed the prop to the implementation, checked if it exists, and if not, set the default color, like before.Test plan
I visually tested the Colorful Pickers example in UIExplorer. Those picker
Items pass in acolorprop.The basic picker does not pass the color prop to the picker
Item, and there are no errors. Basic functionality is still in tact: