Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.43.3 [TextInput] multiline={true} in Android can not create newLine when I enter Soft KeyBoard of return. #13506

Closed
xuyuanzhou opened this issue Apr 14, 2017 · 10 comments
Closed

0.43.3 [TextInput] multiline={true} in Android can not create newLine when I enter Soft KeyBoard of return. #13506

xuyuanzhou opened this issue Apr 14, 2017 · 10 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@xuyuanzhou
Copy link

xuyuanzhou commented Apr 14, 2017 •
edited

0.43.3 [TextInput] multiline={true} in Android can not create newLine when I enter Soft KeyBoard of return.
@xuyuanzhou xuyuanzhou changed the title [TextInput] multiline={true} in Android can not create newLine when I enter Soft KeyBoard of return. 0.43.3 [TextInput] multiline={true} in Android can not create newLine when I enter Soft KeyBoard of return. Apr 14, 2017
@hoangpham95
Copy link

Could you put a code snippet?

@ksegla
Copy link

ksegla commented Apr 17, 2017

I have the exact same problem.
It used to work before. Last version I remember where it used to work is 0.41.

As for a code snippet, something as simple as the following exhibits the bug.

<View> <TextInput multiline={true} numberOfLines={3} /> </View>

@zhangzhhz
Copy link

zhangzhhz commented Apr 19, 2017 •
edited

There is an issue opened already for this. #12717. Broke since 0.42. Still not resolved in 0.43.3.

@kevinluvian kevinluvian mentioned this issue May 10, 2017
Closed
@ZHT131
Copy link

ZHT131 commented Jul 9, 2017

0.46 have you solved the problem?

@ZHT131
Copy link

ZHT131 commented Jul 9, 2017

Has anyone solved the problem of not adding new lines?

samueljmurray pushed a commit to madebymany/react-native that referenced this issue Jul 13, 2017
@kevinluvian @samueljmurray
Fixed new line and prioritise blurOnSubmit in multiline text input
4da017f 
Summary:
What existing problem does the pull request solve?
this fixes facebook#13506 and facebook#12717 where:
- there are some issues when pressing enter with some keyboard
- blurOnSubmit is not working with multiline

I think this should be in stable branch as this is pretty critical, isn't it?

- just create a TextInput with multiline and press enter with samsung keyboard
before, it won't create a new line, now it will.

- just create a TextInput with multiline and blurOnSubmit true and press enter
before, it won't blur, and wont create a new line (on some keyboard, it will create a new line), now it will blur only
Closes facebook#13890

Reviewed By: achen1

Differential Revision: D5333464

Pulled By: shergin

fbshipit-source-id: a0597d1b1967d4de1486e728e03160e1bb15afeb
@codewithpassion
Copy link

@ZHT131 check out https://gist.github.com/catchin/47afe706256604959c13dc25e7bb9383
That works for me. 048.1 still didn't work for me via Expo.

@kkusanagi
Copy link

new line work on 0.41.
starting 0.42 and above until 0.49 still NOT Working.

@anandsai79
Copy link

I'm also facing the same issue, let me know if anyone found solution for this...

@kkusanagi
Copy link

kkusanagi commented Dec 13, 2017 •
edited

install 0.51 React native will fixed all the problem.

also use gradle 2.3.3 and above

@sturmenta
Copy link

I added this line and it worked correctly:
style={{minHeight: 150, height: 'auto'}}

<TextInput
	onChangeText={val => this.setState({ text: val})}
	value={this.state.text}
	multiline
	style={{minHeight: 150, height: 'auto'}}
/>

@facebook facebook locked as resolved and limited conversation to collaborators Jul 9, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed new line and prioritise blurOnSubmit in multiline text input kevinluvian/react-native
10 participants
@codewithpassion @kkusanagi @ksegla @hoangpham95 @xuyuanzhou @ZHT131 @zhangzhhz @anandsai79 @sturmenta @react-native-bot