Added comment to the docs that saveImageWithTag is deprecated #14345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
facebook-github-bot
added
GH Review: accepted
Import Started
|
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
bartolkaruza
pushed a commit
to bartolkaruza/react-native-cameraroll
that referenced
this pull request
Feb 23, 2019
Summary: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. The CameraRoll docs have a method for `saveImageWithTag`. I wanted to know how to use it and how it differs from the other methods. So I open the react-native repo and used the source. I discovered this method is deprecated. It does use a console warning to notify upon use. A developer should not have to use a deprecated method to know it's no longer supported. The docs should state this until it is removed from the library. ```bash git clone https://github.com/facebook/react-native.git cd react-native npm install cd website npm install npm start open http://localhost:8079/react-native/docs/cameraroll.html ``` Verify there are comments for `saveImageWithTag` method notifying developers that it is deprecated. Closes facebook/react-native#14345 Differential Revision: D5198453 Pulled By: shergin fbshipit-source-id: 2b74120a1ee450b903cdcff3812a83747dac5bb8
bartolkaruza
pushed a commit
to bartolkaruza/react-native-cameraroll
that referenced
this pull request
Feb 24, 2019
Summary: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. The CameraRoll docs have a method for `saveImageWithTag`. I wanted to know how to use it and how it differs from the other methods. So I open the react-native repo and used the source. I discovered this method is deprecated. It does use a console warning to notify upon use. A developer should not have to use a deprecated method to know it's no longer supported. The docs should state this until it is removed from the library. ```bash git clone https://github.com/facebook/react-native.git cd react-native npm install cd website npm install npm start open http://localhost:8079/react-native/docs/cameraroll.html ``` Verify there are comments for `saveImageWithTag` method notifying developers that it is deprecated. Closes facebook/react-native#14345 Differential Revision: D5198453 Pulled By: shergin fbshipit-source-id: 2b74120a1ee450b903cdcff3812a83747dac5bb8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterbranch, NOT a "stable" branch.Motivation (required)
The CameraRoll docs have a method for
saveImageWithTag. I wanted to know how to use it and how it differs from the other methods. So I open the react-native repo and used the source.I discovered this method is deprecated. It does use a console warning to notify upon use. A developer should not have to use a deprecated method to know it's no longer supported. The docs should state this until it is removed from the library.
Test Plan (required)
Run the website locally
Verify there are comments for
saveImageWithTagmethod notifying developers that it is deprecated.