-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore babelrc in git-upgrade #20790
Conversation
Per [this comment on the issue](facebook#20710 (comment)): > Babel by default tries to find .babelrc files to configure itself, and once it finds the one from the RN app (which links to the RN preset that only works on Babel 7) it fails. > The easiest patch to fix this issue is to add babelrc: false to the babel-register method, so Babel does not read any additional .babelrc file. Fixes facebook#20710
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
@facebook-github-bot CLA signed |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
👋 thanks for submitting! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
I originally marked this as [INTERNAL], but I'm now realizing this will require a new version of |
I've edited the imported diff to use CLI instead of INTERNAL in the release notes. |
Summary: Per [this comment on the issue](#20710 (comment)): > Babel by default tries to find .babelrc files to configure itself, and once it finds the one from the RN app (which links to the RN preset that only works on Babel 7) it fails. > The easiest patch to fix this issue is to add babelrc: false to the babel-register method, so Babel does not read any additional .babelrc file. Fixes #20710 Pull Request resolved: #20790 Differential Revision: D9458502 Pulled By: hramos fbshipit-source-id: 3a0ed7261322fdd9e0c0840f8a3944974f38b233
This pull request was closed by @ngraef in b4a8630. Once this commit is added to a release, you will see the corresponding version tag below the description at b4a8630. If the commit has a single |
Summary: Per [this comment on the issue](facebook#20710 (comment)): > Babel by default tries to find .babelrc files to configure itself, and once it finds the one from the RN app (which links to the RN preset that only works on Babel 7) it fails. > The easiest patch to fix this issue is to add babelrc: false to the babel-register method, so Babel does not read any additional .babelrc file. Fixes facebook#20710 Pull Request resolved: facebook#20790 Differential Revision: D9458502 Pulled By: hramos fbshipit-source-id: 3a0ed7261322fdd9e0c0840f8a3944974f38b233
Summary: Per [this comment on the issue](facebook#20710 (comment)): > Babel by default tries to find .babelrc files to configure itself, and once it finds the one from the RN app (which links to the RN preset that only works on Babel 7) it fails. > The easiest patch to fix this issue is to add babelrc: false to the babel-register method, so Babel does not read any additional .babelrc file. Fixes facebook#20710 Pull Request resolved: facebook#20790 Differential Revision: D9458502 Pulled By: hramos fbshipit-source-id: 3a0ed7261322fdd9e0c0840f8a3944974f38b233
Summary: Per [this comment on the issue](facebook#20710 (comment)): > Babel by default tries to find .babelrc files to configure itself, and once it finds the one from the RN app (which links to the RN preset that only works on Babel 7) it fails. > The easiest patch to fix this issue is to add babelrc: false to the babel-register method, so Babel does not read any additional .babelrc file. Fixes facebook#20710 Pull Request resolved: facebook#20790 Differential Revision: D9458502 Pulled By: hramos fbshipit-source-id: 3a0ed7261322fdd9e0c0840f8a3944974f38b233
Per this comment on the issue:
Fixes #20710
Test Plan:
Output from react-native-git-upgrade:
Release Notes:
[INTERNAL] [BUGFIX] [react-native-git-upgrade/cli.js] - Prevent react-native-git-upgrade from using project's Babel 7 .babelrc