Bump xcode@1.0.0 #21766
Bump xcode@1.0.0 #21766
Conversation
(cordova-node-)xcode 1.0.0 includes a fix for facebook#13160 plus a few more fixes. This should increase robustness in Xcode project handling overall. Fixes facebook#13160.
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
added
Import Failed
and removed
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
|
@peat-psuwit merged commit b951499 into |
Summary: (cordova-node-)xcode 1.0.0 includes a fix for #13160 plus a few more fixes. This should increase robustness in Xcode project handling overall. Fixes #13160. ------------------------- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. _Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_ Pull Request resolved: #21766 Reviewed By: codytwinton Differential Revision: D10384245 Pulled By: hramos fbshipit-source-id: 488156be67cfc2d99ca81d7cb82747bab35984a7
Summary: (cordova-node-)xcode 1.0.0 includes a fix for facebook#13160 plus a few more fixes. This should increase robustness in Xcode project handling overall. Fixes facebook#13160. ------------------------- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. _Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_ Pull Request resolved: facebook#21766 Reviewed By: codytwinton Differential Revision: D10384245 Pulled By: hramos fbshipit-source-id: 488156be67cfc2d99ca81d7cb82747bab35984a7
(cordova-node-)xcode 1.0.0 includes a fix for #13160 plus a few more
fixes. This should increase robustness in Xcode project handling
overall.
Fixes #13160.
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.
If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!
Test Plan:
Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
react-native-restart, which is linked to iOS project.Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
-- I'm sorry. I'm not sure how to write a changelog for a dependency bump.