Prepend passed sourceExts to default ones and pass them to metro #21855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
analysis-bot
suggested changes
Oct 18, 2018
Fixes react-native start not using passed --sourceExts facebook#21854
elyalvarado
force-pushed
the
fixRunServerSourceExts
branch
from
838bd9f
to
b86073c
Compare
|
@grabbou can you please check this? Is a documented feature that is not working with the latest release |
|
Thank you for submitting this PR. I'll let @rafeca to take a look at it as he is more familiar with Metro. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Oct 30, 2018
There was a problem hiding this comment.
rafeca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@elyalvarado merged commit ce86080 into |
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Nov 6, 2018
…855) Summary: Fixes react-native start not using passed --sourceExts #21854 Pull Request resolved: facebook/react-native#21855 Differential Revision: D12840358 Pulled By: rafeca fbshipit-source-id: 4ee09341b5128d83274a39d8d01c13749efaa78b
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
…ebook#21855) Summary: Fixes react-native start not using passed --sourceExts facebook#21854 Pull Request resolved: facebook#21855 Differential Revision: D12840358 Pulled By: rafeca fbshipit-source-id: 4ee09341b5128d83274a39d8d01c13749efaa78b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes react-native start not using passed --sourceExts #21854
Test Plan:
Release Notes:
[CLI] [BUGFIX] [ local-cli/server/runServer.js] - Pass down --sourceExts to metro packager (fixes regression)