bump gradle to 5.0 #23324
bump gradle to 5.0 #23324
Conversation
facebook-github-bot
added
CLA Signed
|
It was easy because we were tracking Gradle, plugins and addressed deprecation warnings on timely manner 👍 |
react-native-bot
added
Platform: Android
|
Thank you, looks like tests are passing. We'll need to bump the Gradle version used to populate our offline cache internally as well when we import this. Are there any concerns with how this may affect end users? |
|
It may affects users/developers who have custom gradle scripts (brownfield apps) that use removed APIs. We've been fixing deprecation warnings, thus have no issue with this upgrade. |
|
@hramos tested it locally before submitting the PR, and confirmed that RNTester works just fine. |
There was a problem hiding this comment.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
I've upgraded to Gradle 5.0 in the internal version of this PR. The internal diff was approved by @mdvacca.
@dulmandakh there is a separate PR that bumps Gradle to 4.10.3. Which version do you recommend we got with?
|
Let's bump it to 5.0 😉
|
dulmandakh
changed the title
|
@hramos remove Android Gradle Plugin bump to create another PR and cherry pick to 0.59 branch. |
Summary: Bump Android Plugin to 3.3.1, with many bug fixes and performance improvements. Split the change from #23324 to make cherry-pick easy to 0.59 branch. [Android] [Changed] - bump Android Plugin to 3.3.1 Pull Request resolved: #23473 Differential Revision: D14099741 Pulled By: cpojer fbshipit-source-id: 7491c49cd2467f1bb8776345bdda2ab9cea11c06
Summary: Bump Android Plugin to 3.3.1, with many bug fixes and performance improvements. Split the change from #23324 to make cherry-pick easy to 0.59 branch. [Android] [Changed] - bump Android Plugin to 3.3.1 Pull Request resolved: #23473 Differential Revision: D14099741 Pulled By: cpojer fbshipit-source-id: 7491c49cd2467f1bb8776345bdda2ab9cea11c06
|
@dulmandakh merged commit b4017a9 into |
Summary: This PR bumps gradle to 5.0, which includes Kotlin DSL 1.0, and android gradle plugin to 3.3.1, which includes includes various bug fixes and performance improvements. Also Gradle 5.x requires Java 8. This is preparation for Kotlin DSL migration. [Android] [Changed] - Bump Gradle to 5.0 Pull Request resolved: facebook#23324 Reviewed By: mdvacca Differential Revision: D14028563 Pulled By: hramos fbshipit-source-id: 61fe1a2d4ea5707d6f07945acbd950f852420e13
Summary: This PR bumps gradle to 5.0, which includes Kotlin DSL 1.0, and android gradle plugin to 3.3.1, which includes includes various bug fixes and performance improvements. Also Gradle 5.x requires Java 8. This is preparation for Kotlin DSL migration. [Android] [Changed] - Bump Gradle to 5.0 Pull Request resolved: #23324 Reviewed By: mdvacca Differential Revision: D14028563 Pulled By: hramos fbshipit-source-id: 61fe1a2d4ea5707d6f07945acbd950f852420e13
Summary: This PR bumps gradle to 5.0, which includes Kotlin DSL 1.0, and android gradle plugin to 3.3.1, which includes includes various bug fixes and performance improvements. Also Gradle 5.x requires Java 8. This is preparation for Kotlin DSL migration. [Android] [Changed] - Bump Gradle to 5.0 Pull Request resolved: facebook/react-native#23324 Reviewed By: mdvacca Differential Revision: D14028563 Pulled By: hramos fbshipit-source-id: 61fe1a2d4ea5707d6f07945acbd950f852420e13
Summary
This PR bumps gradle to 5.0, which includes Kotlin DSL 1.0. Also Gradle 5.x requires Java 8.
This is preparation for Kotlin DSL migration.
Changelog
[Android] [Changed] - Bump Gradle to 5.0
Test Plan
CI is green, and RNTester builds, runs as normal.