RN: Upgrade ESLint Packages #32560
Closed
RN: Upgrade ESLint Packages #32560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Base commit: 74b91c5 |
Base commit: 74b91c5 |
Summary: Ignores the `Libraries/Renderer/` directory of files which are synchronized from React (and should not be modified). Also, formats some EventEmitter modules that for some reason were missed when I upgraded to Prettier v2.x. ## Changelog [Internal] Pull Request resolved: facebook#32524 Test Plan: ``` yarn run format-check ``` Differential Revision: D32129837 Pulled By: yungsters fbshipit-source-id: c013ead64fc4b4844f9848cd79f02e121fce3ab5
Summary: Instead of using `.prettierrc` to ignore the files sync'd from React, replace `format` with `noformat`. This is necessary because currently, the version of Prettier used in React Native (v2.4.1) differs from the version used in React (v1.19.1). We can revert this when React is upgraded. Changelog: [Internal] Differential Revision: D32129937 fbshipit-source-id: 7393560f49c391680f49eaab8d45681e0151f4f0
Summary: Upgrades ESLint to v7.28.0. This is the latest version before v8.0.0, which would be a more involved upgrade. Upgrades all ESLint-related dependencies to their latest version, except for [eslint-plugin-flowtype](https://github.com/gajus/eslint-plugin-flowtype/). This is because eslint-plugin-flowtype@8.0.0 dropped support for ESLint v7. Configures ESLint for Metro to extend `plugin:prettier/recommended`. ## Changelog [General][Changed] - Upgraded packages to the latest versions for ESLint v7. Pull Request resolved: facebook#32560 Test Plan: Run this on an open source checkout of `facebook/react-native`: ``` # See no new errors or warnings. $ yarn run lint ``` Run this internally: ``` $ js1 test xplat/js/tools/__tests__/dependency-constraints-test.js ``` Verify linting works: ``` js1 lint xplat/js/RKJSModules/Libraries/Core/ ``` Differential Revision: D32258399 Pulled By: yungsters fbshipit-source-id: 6b19c1e2db13712103c5a1d504d68b3af4952ee6
|
This pull request was exported from Phabricator. Differential Revision: D32258399 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 9, 2021
Summary: Upgrades ESLint to v7.28.0. This is the latest version before v8.0.0, which would be a more involved upgrade. Upgrades all ESLint-related dependencies to their latest version, except for [eslint-plugin-flowtype](https://github.com/gajus/eslint-plugin-flowtype/). This is because eslint-plugin-flowtype@8.0.0 dropped support for ESLint v7. Configures ESLint for Metro to extend `plugin:prettier/recommended`. ## Changelog [General][Changed] - Upgraded packages to the latest versions for ESLint v7. Pull Request resolved: #32560 Test Plan: Run this on an open source checkout of `facebook/react-native`: ``` # See no new errors or warnings. $ yarn run lint ``` Run this internally: ``` $ js1 test xplat/js/tools/__tests__/dependency-constraints-test.js ``` Verify linting works: ``` js1 lint xplat/js/RKJSModules/Libraries/Core/ ``` Reviewed By: lunaleaps Differential Revision: D32258399 Pulled By: yungsters fbshipit-source-id: d11b3fc3e33770157a90f3dee352cf80b39c442c
|
This pull request was successfully merged by @yungsters in cf763cd. When will my fix make it into a release? | Upcoming Releases |
|
For this to work with eslint 8 and typescript, the eslint-typescript plugin needs to be upgraded to the latest version (5.4.0). @yungsters you would like me to do a PR for it? |
|
@wcandillon, sure! Thanks. |
|
@wcandillon Were you able to set up a PR to upgrade the eslint-typescript plugin to support eslint v8? 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades ESLint to v7.28.0. This is the latest version before v8.0.0, which would be a more involved upgrade.
Upgrades all ESLint-related dependencies to their latest version, except for eslint-plugin-flowtype. This is because eslint-plugin-flowtype@8.0.0 dropped support for ESLint v7.
Changelog
[General][Changed] - Upgraded packages to the latest versions for ESLint v7.
Test Plan