Use relative installation root instead of absolute to avoid embedding absolute paths in pods project

[danilobuerger]

Summary

Use relative installation root instead of absolute to avoid embedding absolute paths in pods project
Also removes a leading space from each path.

Before:

After:

Changelog

[iOS] [Fixed] - Remove absolute paths from pods project

Test Plan

Pod install and view in Xcode FBReactNativeSpec -> Build Phases -> [CP-User] Generate Specs

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: a0511a1
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,204,201	-8,462
android	hermes	armeabi-v7a	7,811,068	+12,280
android	hermes	x86	8,575,744	-10,333
android	hermes	x86_64	8,526,542	-10,237
android	jsc	arm64-v8a	9,872,944	-8,486
android	jsc	armeabi-v7a	8,864,360	+12,259
android	jsc	x86	9,840,570	-10,351
android	jsc	x86_64	10,435,497	-10,259

Base commit: a0511a1
Branch: main

[danilobuerger]

This seems to fail because of a cyclic dependency between rntester and codegen. I don't really know if this is related and/or how to fix this.

[cortinico]

I think the best reviewer here is @dmitryrykun as he was looking into relative path support for iOS inside our cocoapods setup 👍

[facebook-github-bot]

@dmitryrykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cortinico]

@danilobuerger Just a heads up that @dmitryrykun is off this week so this will take a bit longer 👍

[dmytrorykun]

@danilobuerger these changes break the build of RNTester (and potentially any project with turbo modules). I'll take look into what's going on there, but it may take a while. Any help is appreciated.

[danilobuerger]

@dmitryrykun It looks like a real cyclic dependency in Xcode to me:

Target "ScreenshotManager" depends on Target "React" depends on Target "React-RCTAnimation" depends on Target "React-Codegen".

Task "React-Codegen" has a Build Phase "Compile Sources" with an Input file:

../build/generated/ios/./ScreenshotmanagerSpec/ScreenshotmanagerSpec-generated.mm

This Input file is listed as an Output file in "ScreenshotManager" Build Phase "[CP-User] Generate Specs".

This PR fixed the paths so that Xcode saw the dependency cycle.

[danilobuerger]

@dmitryrykun Changing ScreenshotManagers dependency from React to React-Core seems to successfully build. However, I am unsure if this is correct?

[danilobuerger]

I remember a while back there was a massive change from dependency React => React-Core in third party libraries. I found #29633 (comment) maybe the ScreenshotManager was just forgotten?

[danilobuerger]

@dmitryrykun all checks are green now. Hopefully this is the right approach.

It would be nice to get this into 0.68 so that we don't have hardcoded absolute paths in a lot of projects that could potentially break and lead to hard to debug issues.

[dmytrorykun]

Great job, thank you for getting it done!

[facebook-github-bot]

@dmitryrykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @danilobuerger in 42b01a3.

^{When will my fix make it into a release? | Upcoming Releases}