Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass string by ref in TurboModule template #33970

Closed
wants to merge 1 commit into from

Conversation

janicduplessis
Copy link
Contributor

Summary

3337add made some changes to method signature but the template wasn't updated. This adds the missing changes.

Changelog

[Internal] [Fixed] - Pass string by ref in TurboModule template

Test Plan

Didn't test the template directly, but the change is trivial.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 7, 2022
@janicduplessis
Copy link
Contributor Author

cc @javache

@facebook-github-bot facebook-github-bot added Contributor A React Native contributor. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jun 7, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,782,201 -71
android hermes armeabi-v7a 7,172,014 -63
android hermes x86 8,092,856 -78
android hermes x86_64 8,068,863 -75
android jsc arm64-v8a 9,649,172 +70
android jsc armeabi-v7a 8,407,940 +71
android jsc x86 9,600,695 +65
android jsc x86_64 10,193,737 +72

Base commit: b0c2b10
Branch: main

@facebook-github-bot
Copy link
Contributor

@dmitryrykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: b0c2b10
Branch: main

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @janicduplessis

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @janicduplessis in 9ef3045.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 7, 2022
@janicduplessis janicduplessis deleted the fix-template branch June 7, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants