-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix React module build error with swift integration on new architecture mode #34527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Contributor
A React Native contributor.
p: Expo
Partner: Expo
Partner
labels
Aug 29, 2022
Base commit: a45eeea |
Base commit: a45eeea |
facebook-github-bot
added
the
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
label
Aug 29, 2022
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @Kudo in 3afef3c. When will my fix make it into a release? | Upcoming Releases |
dmytrorykun
pushed a commit
that referenced
this pull request
Sep 14, 2022
…re mode (#34527) Summary: when integrates with swift, the compiler will build clang module based on the *React-Core-umbrella.h*. however, the include chain reaches some c++ headers that are not available from swift. it will cause build error. ![Screen Shot 2022-08-29 at 8 25 08 PM](https://user-images.githubusercontent.com/46429/187200668-2a1f12c9-61e5-4d8b-9531-69ff5c1a5741.png) this pr adds `#ifdef __cplusplus` guard for it. ## Changelog [iOS] [Fixed] - Fix React module build error with swift integration on new architecture mode Pull Request resolved: #34527 Test Plan: one thing we didn't figure out is that we require reanimated to repro the build error. 1. `npx react-native init RN070 --version 0.70.0-rc.4`. # can also repro this issue on 0.69 2. `cd RN070` 3. `yarn add react-native-reanimated@next` 4. `cd ios && rm -rf Pods build && RCT_NEW_ARCH_ENABLED=1 pod install` 5. add `import React;` in `main.m` for clang module generation ```diff --- a/ios/RN070/main.m +++ b/ios/RN070/main.m @@ -1,5 +1,6 @@ #import <UIKit/UIKit.h> +@import React; #import "AppDelegate.h" int main(int argc, char *argv[]) ``` 6. `yarn ios` Reviewed By: cipolleschi Differential Revision: D39128716 Pulled By: jacdebug fbshipit-source-id: d9e9130f99e3b9e5f7807c475a24cdd84880e720
Titozzz
pushed a commit
that referenced
this pull request
Sep 26, 2022
…re mode (#34527) Summary: when integrates with swift, the compiler will build clang module based on the *React-Core-umbrella.h*. however, the include chain reaches some c++ headers that are not available from swift. it will cause build error. ![Screen Shot 2022-08-29 at 8 25 08 PM](https://user-images.githubusercontent.com/46429/187200668-2a1f12c9-61e5-4d8b-9531-69ff5c1a5741.png) this pr adds `#ifdef __cplusplus` guard for it. ## Changelog [iOS] [Fixed] - Fix React module build error with swift integration on new architecture mode Pull Request resolved: #34527 Test Plan: one thing we didn't figure out is that we require reanimated to repro the build error. 1. `npx react-native init RN070 --version 0.70.0-rc.4`. # can also repro this issue on 0.69 2. `cd RN070` 3. `yarn add react-native-reanimated@next` 4. `cd ios && rm -rf Pods build && RCT_NEW_ARCH_ENABLED=1 pod install` 5. add `import React;` in `main.m` for clang module generation ```diff --- a/ios/RN070/main.m +++ b/ios/RN070/main.m @@ -1,5 +1,6 @@ #import <UIKit/UIKit.h> +@import React; #import "AppDelegate.h" int main(int argc, char *argv[]) ``` 6. `yarn ios` Reviewed By: cipolleschi Differential Revision: D39128716 Pulled By: jacdebug fbshipit-source-id: d9e9130f99e3b9e5f7807c475a24cdd84880e720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Contributor
A React Native contributor.
Merged
This PR has been merged.
p: Expo
Partner: Expo
Partner
Platform: iOS
iOS applications.
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
when integrates with swift, the compiler will build clang module based on the React-Core-umbrella.h. however, the include chain reaches some c++ headers that are not available from swift. it will cause build error.
this pr adds
#ifdef __cplusplus
guard for it.Changelog
[iOS] [Fixed] - Fix React module build error with swift integration on new architecture mode
Test Plan
one thing we didn't figure out is that we require reanimated to repro the build error.
npx react-native init RN070 --version 0.70.0-rc.4
. # can also repro this issue on 0.69cd RN070
yarn add react-native-reanimated@next
cd ios && rm -rf Pods build && RCT_NEW_ARCH_ENABLED=1 pod install
@import React;
inmain.m
for clang module generationyarn ios