Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextInput's inputMode TypeScript types #35987

Closed
wants to merge 2 commits into from

Conversation

eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Jan 27, 2023

Summary

Forward-porting DefinitelyTyped/DefinitelyTyped#64100

Changelog

[GENERAL] [FIXED] - Add TextInput's inputMode TypeScript types

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 27, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,463,326 +0
android hermes armeabi-v7a 7,783,679 +0
android hermes x86 8,936,307 +0
android hermes x86_64 8,794,206 +0
android jsc arm64-v8a 9,648,910 +0
android jsc armeabi-v7a 8,383,186 +0
android jsc x86 9,710,882 +0
android jsc x86_64 10,187,743 +0

Base commit: d3cc48d
Branch: main

@facebook-github-bot
Copy link
Contributor

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 27, 2023
@facebook-github-bot
Copy link
Contributor

@jacdebug merged this pull request in fac7859.

@eps1lon eps1lon deleted the patch-1 branch January 27, 2023 18:08
kelset pushed a commit that referenced this pull request Jan 30, 2023
Summary:
Forward-porting DefinitelyTyped/DefinitelyTyped#64100

## Changelog

[GENERAL] [FIXED] - Add `TextInput`'s `inputMode` TypeScript types

Pull Request resolved: #35987

Test Plan: - [x] DefinitelyTyped/DefinitelyTyped#64100 green

Reviewed By: christophpurrer

Differential Revision: D42799862

Pulled By: jacdebug

fbshipit-source-id: b387fd8bc53e66d6125fee810862de3e292e6e74
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Forward-porting DefinitelyTyped/DefinitelyTyped#64100

## Changelog

[GENERAL] [FIXED] - Add `TextInput`'s `inputMode` TypeScript types

Pull Request resolved: facebook#35987

Test Plan: - [x] DefinitelyTyped/DefinitelyTyped#64100 green

Reviewed By: christophpurrer

Differential Revision: D42799862

Pulled By: jacdebug

fbshipit-source-id: b387fd8bc53e66d6125fee810862de3e292e6e74
@cipolleschi cipolleschi mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants