-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enterKeyHint in TextInput type declaration #37624
Closed
tarunrajput
wants to merge
1
commit into
facebook:main
from
tarunrajput:add-TextInput-enterKeyHint-missing-declaration-types
Closed
Add enterKeyHint in TextInput type declaration #37624
tarunrajput
wants to merge
1
commit into
facebook:main
from
tarunrajput:add-TextInput-enterKeyHint-missing-declaration-types
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
May 30, 2023
Base commit: 7f22db8 |
tarunrajput
force-pushed
the
add-TextInput-enterKeyHint-missing-declaration-types
branch
from
May 30, 2023 18:32
de7e0f1
to
73d6657
Compare
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Updated docs as well to add missing |
@lunaleaps merged this pull request in 5062553. |
tarunrajput
deleted the
add-TextInput-enterKeyHint-missing-declaration-types
branch
June 27, 2023 11:13
lunaleaps
pushed a commit
that referenced
this pull request
Aug 7, 2023
Summary: Resolves: #37622 Related: #34482 https://reactnative.dev/docs/textinput#enterkeyhint ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal][Added]: Add enterKeyHint in TextInput type declaration Pull Request resolved: #37624 Reviewed By: cortinico, NickGerleman Differential Revision: D46292040 Pulled By: lunaleaps fbshipit-source-id: a037b7f8dd0d60880dcf1aec64749546fa54a95d
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
This PR has been merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Resolves: #37622
Related:
#34482
https://reactnative.dev/docs/textinput#enterkeyhint
Changelog:
[Internal][Added]: Add enterKeyHint in TextInput type declaration
Test Plan: