Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enterKeyHint in TextInput type declaration #37624

Conversation

tarunrajput
Copy link
Contributor

@tarunrajput tarunrajput commented May 30, 2023

Summary:

Resolves: #37622

Related:
#34482
https://reactnative.dev/docs/textinput#enterkeyhint

Changelog:

[Internal][Added]: Add enterKeyHint in TextInput type declaration

Test Plan:

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 30, 2023
@analysis-bot
Copy link

analysis-bot commented May 30, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,744,596 +4
android hermes armeabi-v7a 8,056,237 +4
android hermes x86 9,235,405 +4
android hermes x86_64 9,086,283 +4
android jsc arm64-v8a 9,307,301 +2
android jsc armeabi-v7a 8,496,538 +5
android jsc x86 9,369,188 +4
android jsc x86_64 9,624,180 +3

Base commit: 7f22db8
Branch: main

@tarunrajput tarunrajput force-pushed the add-TextInput-enterKeyHint-missing-declaration-types branch from de7e0f1 to 73d6657 Compare May 30, 2023 18:32
@tarunrajput tarunrajput marked this pull request as ready for review May 30, 2023 18:33
@facebook-github-bot
Copy link
Contributor

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tarunrajput
Copy link
Contributor Author

Updated docs as well to add missing go value and mark enter as iOS only
PR: facebook/react-native-website#3739

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 5, 2023
@facebook-github-bot
Copy link
Contributor

@lunaleaps merged this pull request in 5062553.

@tarunrajput tarunrajput deleted the add-TextInput-enterKeyHint-missing-declaration-types branch June 27, 2023 11:13
lunaleaps pushed a commit that referenced this pull request Aug 7, 2023
Summary:
Resolves: #37622

Related:
#34482
https://reactnative.dev/docs/textinput#enterkeyhint

## Changelog:

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[Internal][Added]: Add enterKeyHint in TextInput type declaration

Pull Request resolved: #37624

Reviewed By: cortinico, NickGerleman

Differential Revision: D46292040

Pulled By: lunaleaps

fbshipit-source-id: a037b7f8dd0d60880dcf1aec64749546fa54a95d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enterKeyHint is missing from TextInputProps type
3 participants