Localize Voiceover strings in Fabric #37679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46426571 |
Base commit: 3a246ed |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 8, 2023
Summary: Pull Request resolved: facebook#37679 This reuses the localizations from the last diff on the stack, on top of the new logic added with D45797554. Changelog: [iOS][Fixed] - Localize Voiceover strings in Fabric Reviewed By: philIip Differential Revision: D46426571 fbshipit-source-id: 035f339953de6c33b8bb7621cb62f5b9b9c6d762
NickGerleman
force-pushed
the
export-D46426571
branch
from
4ace7ab
to
fe05f34
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46426571 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 8, 2023
Summary: Pull Request resolved: facebook#37679 This reuses the localizations from the last diff on the stack, on top of the new logic added with D45797554. Changelog: [iOS][Fixed] - Localize Voiceover strings in Fabric Reviewed By: philIip Differential Revision: D46426571 fbshipit-source-id: 450944e470e8286c04f49b181fb436a0061e1878
NickGerleman
force-pushed
the
export-D46426571
branch
from
fe05f34
to
a5eebee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46426571 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 8, 2023
Summary: Pull Request resolved: facebook#37679 This reuses the localizations from the last diff on the stack, on top of the new logic added with D45797554. Changelog: [iOS][Fixed] - Localize Voiceover strings in Fabric Reviewed By: philIip Differential Revision: D46426571 fbshipit-source-id: b95e30f9e9fa0c49b81afbc1526e336332936f0a
NickGerleman
force-pushed
the
export-D46426571
branch
from
a5eebee
to
c8918f2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46426571 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 8, 2023
Summary: Pull Request resolved: facebook#37679 This reuses the localizations from the last diff on the stack, on top of the new logic added with D45797554. Changelog: [iOS][Fixed] - Localize Voiceover strings in Fabric Reviewed By: philIip Differential Revision: D46426571 fbshipit-source-id: e9a7a11be36aac72ffbe71bbe8b95594f216a89a
NickGerleman
force-pushed
the
export-D46426571
branch
from
c8918f2
to
e89390e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46426571 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 11, 2023
Summary: Pull Request resolved: facebook#37679 This reuses the localizations from the last diff on the stack, on top of the new logic added with D45797554. Changelog: [iOS][Fixed] - Localize Voiceover strings in Fabric Reviewed By: philIip Differential Revision: D46426571 fbshipit-source-id: 4905c363f1f7d9a2ead5594c7169be020097fc88
NickGerleman
force-pushed
the
export-D46426571
branch
from
e89390e
to
54aa406
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46426571 |
Differential Revision: https://internalfb.com/D46399962 fbshipit-source-id: ccc5d022f1db4ab753cf7cc63456790db0552d74
Differential Revision: D46414631 fbshipit-source-id: e11ad82bd4a8a26d5b9fe530a73b47e85965b1a8
…CocoaPods Summary: ## Stack React Native on iOS adds strings to Voiceover interactions to supply more information to users . Internally, and out-of-the-box externally, these are today always announced in English instead of being localized. This stack adds a limited new internal API, `RCTLocalizedString(string, description)` to allow auto-translated strings which are consumed by both Meta and OSS. Differential Revision: https://www.internalfb.com/diff/D46414630?entry_point=27 fbshipit-source-id: 8226be215bde85db55cc1620fedec10d69cfa759
Differential Revision: D46415273 fbshipit-source-id: cf1bcf15b52c1d2153b4070d58ac2de25bc14bfa
Summary: Pull Request resolved: facebook#37679 This reuses the localizations from the last diff on the stack, on top of the new logic added with D45797554. Changelog: [iOS][Fixed] - Localize Voiceover strings in Fabric Reviewed By: philIip Differential Revision: D46426571 fbshipit-source-id: bc9e915201ed3eef80241e9d290bc1f6ee4bf906
NickGerleman
force-pushed
the
export-D46426571
branch
from
54aa406
to
6083861
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46426571 |
|
This pull request has been merged in 1f45459. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This reuses the localizations from the last diff on the stack, on top of the new logic added with D45797554.
Changelog:
[iOS][Fixed] - Localize Voiceover strings in Fabric
Differential Revision: D46426571