New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minSdk to 23 in RN OSS #38874

Closed

mdvacca wants to merge 1 commit into facebook:main from mdvacca:export-D48177965

Contributor

mdvacca commented Aug 9, 2023

Summary:
In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: NickGerleman

Differential Revision: D48177965

facebook-github-bot added CLA Signed p: Facebook Partner fb-exported labels

Contributor

facebook-github-bot commented Aug 9, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965

analysis-bot commented Aug 9, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	16,902,790	+8,566,579
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,381,598	+10,807,189
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 5203354
Branch: main

Contributor

facebook-github-bot commented Aug 15, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Bump minSdk to 23 in RN OSS (facebook#38874)

4ed6c4a

Summary:
Pull Request resolved: facebook#38874

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

fbshipit-source-id: 2cfdb42eaf28082370bbf7ef39a14293d3b9e031

mdvacca force-pushed the export-D48177965 branch from 3198761 to 4ed6c4a Compare

August 15, 2023 22:16

Contributor

facebook-github-bot commented Aug 22, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965

mdvacca force-pushed the export-D48177965 branch from 4ed6c4a to f7ecb07 Compare

August 22, 2023 00:20

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Bump minSdk to 23 in RN OSS (facebook#38874)

f7ecb07

Summary:
Pull Request resolved: facebook#38874

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

fbshipit-source-id: 688903c81fcee5123155bedc145f490fd743d2c3

Contributor

facebook-github-bot commented Sep 18, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965

mdvacca force-pushed the export-D48177965 branch from f7ecb07 to 1a53cd0 Compare

September 18, 2023 20:42

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Bump minSdk to 23 in RN OSS (facebook#38874)

1a53cd0

Summary:

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

Contributor

facebook-github-bot commented Sep 25, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Bump minSdk to 23 in RN OSS (facebook#38874)

20855cb

Summary:

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

mdvacca force-pushed the export-D48177965 branch from 1a53cd0 to 20855cb Compare

September 25, 2023 16:03

Contributor

ecreeth commented Sep 25, 2023

Why does this change increase the size of the app so much?

mdvacca force-pushed the export-D48177965 branch from 20855cb to 4e5bd15 Compare

September 26, 2023 17:44

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Bump minSdk to 23 in RN OSS (facebook#38874)

4e5bd15

Summary:

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

Contributor

facebook-github-bot commented Sep 26, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Bump minSdk to 23 in RN OSS (facebook#38874)

0dfd6fd

Summary:

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

mdvacca force-pushed the export-D48177965 branch from 4e5bd15 to 0dfd6fd Compare

September 26, 2023 17:46

Contributor

facebook-github-bot commented Sep 26, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Bump minSdk to 23 in RN OSS (facebook#38874)

a61ee3a

Summary:

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

mdvacca force-pushed the export-D48177965 branch from 0dfd6fd to a61ee3a Compare

September 26, 2023 17:55

Contributor

facebook-github-bot commented Sep 26, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965

1 similar comment

Contributor

facebook-github-bot commented Sep 26, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Bump minSdk to 23 in RN OSS (facebook#38874)

44307a7

Summary:

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

mdvacca force-pushed the export-D48177965 branch from a61ee3a to 44307a7 Compare

September 26, 2023 20:36

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Bump minSdk to 23 in RN OSS (facebook#38874)

de29743

Summary:

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

mdvacca force-pushed the export-D48177965 branch from 44307a7 to de29743 Compare

September 26, 2023 20:37

Contributor

facebook-github-bot commented Sep 26, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Bump minSdk to 23 in RN OSS (facebook#38874)

2a0f8ce

Summary:

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

mdvacca force-pushed the export-D48177965 branch from de29743 to 2a0f8ce Compare

September 26, 2023 20:47

Contributor

facebook-github-bot commented Sep 26, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Bump minSdk to 23 in RN OSS (facebook#38874)

fd82339

Summary:

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

mdvacca force-pushed the export-D48177965 branch from 2a0f8ce to fd82339 Compare

September 27, 2023 13:25

Contributor

facebook-github-bot commented Sep 27, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Bump minSdk to 23 in RN OSS (facebook#38874)

85fa2c9

Summary:

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

mdvacca force-pushed the export-D48177965 branch from fd82339 to 85fa2c9 Compare

September 27, 2023 14:22

Contributor

facebook-github-bot commented Sep 27, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Bump minSdk to 23 in RN OSS (facebook#38874)

a82c3f6

Summary:

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

mdvacca force-pushed the export-D48177965 branch from 85fa2c9 to a82c3f6 Compare

September 27, 2023 15:22

Contributor

facebook-github-bot commented Sep 27, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965


          Bump minSdk to 23 in RN OSS (facebook#38874)

675535b

Summary:

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

mdvacca force-pushed the export-D48177965 branch from a82c3f6 to 675535b Compare

September 27, 2023 15:44

Contributor

facebook-github-bot commented Sep 27, 2023

This pull request was exported from Phabricator. Differential Revision: D48177965

github-actions bot commented Sep 27, 2023

	Warnings
⚠️	One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against a82c3f6

github-actions bot commented Sep 27, 2023

This pull request was successfully merged by @mdvacca in 70fcb1e.

^{When will my fix make it into a release? | Upcoming Releases}

github-actions bot added the Merged label

facebook-github-bot closed this in

70fcb1e

dcangulo mentioned this pull request

docs: bump minSdk to 23 #42034

Closed

facebook-github-bot pushed a commit that referenced this pull request


          docs: bump minSdk to 23 (#42034)

192a88d

Summary:
The Android minSdk has been bumped in #38874 but not in the README.

## Changelog:
[General] [Fixed] - Updated docs to match Android 6.0 (API 23) minimum requirement.

Pull Request resolved: #42034

Test Plan: N/A

Reviewed By: fkgozali

Differential Revision: D52364522

Pulled By: arushikesarwani94

fbshipit-source-id: b04b5aa94b629380b559b2717e12a882f8817a6f

Othinn pushed a commit to Othinn/react-native that referenced this pull request


          docs: bump minSdk to 23 (facebook#42034)

94de964

Summary:
The Android minSdk has been bumped in facebook#38874 but not in the README.

## Changelog:
[General] [Fixed] - Updated docs to match Android 6.0 (API 23) minimum requirement.

Pull Request resolved: facebook#42034

Test Plan: N/A

Reviewed By: fkgozali

Differential Revision: D52364522

Pulled By: arushikesarwani94

fbshipit-source-id: b04b5aa94b629380b559b2717e12a882f8817a6f

blakef pushed a commit to blakef/template that referenced this pull request


          Bump minSdk to 23 in RN OSS (#38874)

9aba5ac

Summary:
Pull Request resolved: facebook/react-native#38874

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

fbshipit-source-id: 79f46f6e1674fe9d38dc9dfbe8f0f9a43f39a712

Original: facebook/react-native@70fcb1e

blakef pushed a commit to react-native-community/template that referenced this pull request


          Bump minSdk to 23 in RN OSS (#38874)

5eb0503

Summary:
Pull Request resolved: facebook/react-native#38874

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

fbshipit-source-id: 79f46f6e1674fe9d38dc9dfbe8f0f9a43f39a712

Original-Commit: facebook/react-native@70fcb1e

blakef pushed a commit to react-native-community/template that referenced this pull request


          Bump minSdk to 23 in RN OSS (#38874)

efcc14d

Summary:
Pull Request resolved: facebook/react-native#38874

In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Reviewed By: fkgozali, NickGerleman

Differential Revision: D48177965

fbshipit-source-id: 79f46f6e1674fe9d38dc9dfbe8f0f9a43f39a712

Original-Commit: facebook/react-native@70fcb1e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner