Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Xcode 15 patches to be more robust #39710

Closed
wants to merge 1 commit into from
Closed

Update Xcode 15 patches to be more robust #39710

wants to merge 1 commit into from

Commits on Sep 29, 2023

  1. Update Xcode 15 patches to be more robust (facebook#39710) 

    Summary:
Pull Request resolved: facebook#39710

Last week Apple released Xcode 15, which required us to ship a workaround for the new linker.
Unfortunately, the previous fix was not good enough and there were some edge cases that were not covered.
For example, in some occasions the flags are read as an array and the `-Wl` and the `-ld_classic` flags were separated and not properly removed when moving from Xcode 15 to Xcpde 14.3.1.

This change fixes those edge cases, with a more robust solution where:
- We convert the flags to a string.
- We trim the string and the values properly.
- We add the flags when running `pod install` with Xcode 15 as the default iOS toolchain.
- We remove the flags when running `pod install` with Xcode <15 as the default iOS toolchain.

## Changelog:
[Internal] - Make the Xcode 15 workaround more robust.

Reviewed By: dmytrorykun

Differential Revision: D49748844

fbshipit-source-id: 74a707c86add4b5673e1490fd2b46e30be2ee24c
    @cipolleschi @facebook-github-bot
    cipolleschi authored and facebook-github-bot committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    2d00998 View commit details
    Browse the repository at this point in the history