Add C++ header for default TurboModules and cross-platform reuse #44361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56835783 |
|
This pull request was exported from Phabricator. Differential Revision: D56835783 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
May 1, 2024
…ebook#44361) Summary: Pull Request resolved: facebook#44361 In order to keep all platforms in sync (Android, iOS, Windows, etc.), it makes sense to consolidate all C++ TurboModules that we want available by default on all platforms to a shared C++ header / implementation. This moves the duplicated code from Android and iOS to such a shared module provider and updates relevant build specs. ## Changelog [Internal] Differential Revision: D56835783
|
This pull request was exported from Phabricator. Differential Revision: D56835783 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
May 1, 2024
…ebook#44361) Summary: Pull Request resolved: facebook#44361 In order to keep all platforms in sync (Android, iOS, Windows, etc.), it makes sense to consolidate all C++ TurboModules that we want available by default on all platforms to a shared C++ header / implementation. This moves the duplicated code from Android and iOS to such a shared module provider and updates relevant build specs. ## Changelog [Internal] Differential Revision: D56835783
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
May 1, 2024
…ebook#44361) Summary: Pull Request resolved: facebook#44361 In order to keep all platforms in sync (Android, iOS, Windows, etc.), it makes sense to consolidate all C++ TurboModules that we want available by default on all platforms to a shared C++ header / implementation. This moves the duplicated code from Android and iOS to such a shared module provider and updates relevant build specs. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D56835783
|
This pull request was exported from Phabricator. Differential Revision: D56835783 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
May 1, 2024
…ebook#44361) Summary: Pull Request resolved: facebook#44361 In order to keep all platforms in sync (Android, iOS, Windows, etc.), it makes sense to consolidate all C++ TurboModules that we want available by default on all platforms to a shared C++ header / implementation. This moves the duplicated code from Android and iOS to such a shared module provider and updates relevant build specs. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D56835783
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
May 1, 2024
…ebook#44361) Summary: Pull Request resolved: facebook#44361 In order to keep all platforms in sync (Android, iOS, Windows, etc.), it makes sense to consolidate all C++ TurboModules that we want available by default on all platforms to a shared C++ header / implementation. This moves the duplicated code from Android and iOS to such a shared module provider and updates relevant build specs. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D56835783
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
May 1, 2024
…ebook#44361) Summary: Pull Request resolved: facebook#44361 In order to keep all platforms in sync (Android, iOS, Windows, etc.), it makes sense to consolidate all C++ TurboModules that we want available by default on all platforms to a shared C++ header / implementation. This moves the duplicated code from Android and iOS to such a shared module provider and updates relevant build specs. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D56835783
Base commit: 5399223 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
May 1, 2024
…ebook#44361) Summary: Pull Request resolved: facebook#44361 In order to keep all platforms in sync (Android, iOS, Windows, etc.), it makes sense to consolidate all C++ TurboModules that we want available by default on all platforms to a shared C++ header / implementation. This moves the duplicated code from Android and iOS to such a shared module provider and updates relevant build specs. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D56835783
|
This pull request was exported from Phabricator. Differential Revision: D56835783 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
May 1, 2024
…ebook#44361) Summary: Pull Request resolved: facebook#44361 In order to keep all platforms in sync (Android, iOS, Windows, etc.), it makes sense to consolidate all C++ TurboModules that we want available by default on all platforms to a shared C++ header / implementation. This moves the duplicated code from Android and iOS to such a shared module provider and updates relevant build specs. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D56835783
…ebook#44361) Summary: Pull Request resolved: facebook#44361 In order to keep all platforms in sync (Android, iOS, Windows, etc.), it makes sense to consolidate all C++ TurboModules that we want available by default on all platforms to a shared C++ header / implementation. This moves the duplicated code from Android and iOS to such a shared module provider and updates relevant build specs. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D56835783
|
This pull request has been merged in 67bc65d. |
|
This pull request was successfully merged by @rozele in 67bc65d. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
May 6, 2024
…ebook#44361) Summary: Pull Request resolved: facebook#44361 In order to keep all platforms in sync (Android, iOS, Windows, etc.), it makes sense to consolidate all C++ TurboModules that we want available by default on all platforms to a shared C++ header / implementation. This moves the duplicated code from Android and iOS to such a shared module provider and updates relevant build specs. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D56835783 fbshipit-source-id: 7322ed054ded5749973885c63257e5caf23b3fc3
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…ebook#44361) Summary: Pull Request resolved: facebook#44361 In order to keep all platforms in sync (Android, iOS, Windows, etc.), it makes sense to consolidate all C++ TurboModules that we want available by default on all platforms to a shared C++ header / implementation. This moves the duplicated code from Android and iOS to such a shared module provider and updates relevant build specs. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D56835783 fbshipit-source-id: 7322ed054ded5749973885c63257e5caf23b3fc3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In order to keep all platforms in sync (Android, iOS, Windows, etc.), it makes sense to consolidate all C++ TurboModules that we want available by default on all platforms to a shared C++ header / implementation.
This moves the duplicated code from Android and iOS to such a shared module provider and updates relevant build specs.
Changelog
[Internal]
Differential Revision: D56835783