fix(react-native-xcode): Use CONFIG_CMD if set
#46112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
facebook-github-bot
added
the
Shared with Meta
|
|
@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @krystofwoldrich in 774fe0c When will my fix make it into a release? | How to file a pick request? |
11 tasks
blakef
pushed a commit
that referenced
this pull request
Sep 30, 2024
Summary: In the recent 0.75 release I've noticed new `CONFIG_CMD` option in `react-native-xcode.sh`. But this option was not used. Insted when set `CONFIG_APP` was used. This seems like a bug. As the usage before this PR would be as follow: ```bash export CONFIG_CMD=true export CONFIG_APP="/path/to/node /path/to/node_modules/react-native/cli.js config" ``` After this PR ``` export CONFIG_CMD="/path/to/node /path/to/node_modules/react-native/cli.js config" ``` This PR also removed unused explicite `--config-cmd "$CONFIG"` flag, as this is always overwriten by the code above, by default to `--config-cmd" "$NODE_BINARY $NODE_ARGS $REACT_NATIVE_DIR/cli.js config`. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [iOS][Fixed] - Use CONFIG_CMD if set Pull Request resolved: #46112 Test Plan: I've set `CONFIG_CMD` and run Xcode Release build to check that the set command is executed. Reviewed By: christophpurrer Differential Revision: D61545010 Pulled By: blakef fbshipit-source-id: ebbf8ebc08404bc6816277518a3b86c6f7e41e6e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In the recent 0.75 release I've noticed new
CONFIG_CMDoption inreact-native-xcode.sh. But this option was not used. Insted when setCONFIG_APPwas used.This seems like a bug. As the usage before this PR would be as follow:
After this PR
This PR also removed unused explicite
--config-cmd "$CONFIG"flag, as this is always overwriten by the code above, by default to--config-cmd" "$NODE_BINARY $NODE_ARGS $REACT_NATIVE_DIR/cli.js config.Changelog:
[iOS][Fixed] - Use CONFIG_CMD if set
Test Plan:
I've set
CONFIG_CMDand run Xcode Release build to check that the set command is executed.