fix(android): make getUri and isResource available for override

[shubhamguptadream11]

Summary:

Fixes following issues:

• ImageSource is now open for inheritance but the getUri method is still final and cannot override it #46150
• 'getUri()' cannot override 'getUri()' in 'com.facebook.react.views.imagehelper.ImageSource'; overridden method is final #46155

Changelog:

[ANDROID] [FIXED] - Make getUri and isResource open

Test Plan:

[shubhamguptadream11]

Hi @cortinico,

Could you please take a moment to review this PR when you get a chance? Given its impact, it would be great if we could prioritise it.

Thank you!

[deepanshushuklad11]

@cortinico Please get this PR merged.

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cortinico]

Just a small heads up that this is not the right fix. This file is generated from the Kotlin code, so the code needs to be updated as well. I'll take care of it

[deepanshushuklad11]

@cortinico Can you also explain how this file gets generated for future reference ?

[cortinico]

This file gets generated with ./gradlew apiDump (see https://github.com/Kotlin/binary-compatibility-validator)
Also we regenerate the file internally with Buck so even if you edit it, we'll always regenerate it once we import the PR

[deepanshushuklad11]

So ideally it should run after your PR .
But didn't happen .

[bradfloodx]

How about a "thank you" also there @deepanshushuklad11

Thanks @cortinico

[deepanshushuklad11]

@bradfloodx Yes a big thanks to @cortinico.
Just wanted to clarify my doubts.

[shubhamguptadream11]

@cortinico I understand how the .api file is generated from the Kotlin code now. It looks like I need to mark both the uri and isResource properties as open in ImageSource.kt to ensure they are not marked as final in the .api file.

Here's the change I'm planning to make:

/** Get the URI for this image - can be either a parsed network URI or a resource URI. */
public open val uri: Uri = computeUri(context)

/** Get whether this image source represents an Android resource or a network URI. */
public open var isResource: Boolean = false

I pushed the changes. Let me know if there is any other concern.
Thanks for your guidance.

[facebook-github-bot]

@cortinico merged this pull request in 8c81ffa.

[react-native-bot]

This pull request was successfully merged by @shubhamguptadream11 in 8c81ffa

^{When will my fix make it into a release? | How to file a pick request?}