Escape URL string before creating an NSURL #786
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we make a request that contains a pipe character, URLWithString will return null. This fix escapes these and other characters before creating the NSURL.
facebook-github-bot
added
the
CLA Signed
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 14, 2015
Summary: If we make a request that contains a pipe character, URLWithString will return null. This fix escapes these and other characters before creating the NSURL. Closes facebook#786 Github Author: Blair Vanderhoof <blairv@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 15, 2015
Summary: If we make a request that contains a pipe character, URLWithString will return null. This fix escapes these and other characters before creating the NSURL. Closes facebook#786 Github Author: Blair Vanderhoof <blairv@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
* add onSubmitEditing callback argument documentation * Update textinput.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we make a request that contains a pipe character, URLWithString will return null. This fix escapes these and other characters before creating the NSURL.