Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Merge `rnpm cli` into react-native #7899
This is an initial step of rewriting the CLI interface to use
It's scope is to move all existing commands to use rnpm CLI interface, so that we get plugins, flags and our existing ecosystem working out of the box.
Breaking changes for current
There's plenty of stuff yet to be done, but we are trying to keep the diff small. We still have to post new docs and developers guide. @bestander @vjeux since the local-cli is now extensible and supports custom configs (either through rn-cli or via package.json), can we think of an extra section on the website to describe it?
4 similar comments
2 similar comments
@grabbou, I was able to get a shim for bundle/unbundle/dependencies
But I have a feeling that
Also we plan to opensource this internal CLI code soon.
@bestander I believe it would be much simpler to just call the functions itself directly, though I don't want to introduce extra mess here w/o having an access to the code you are trying to shim. Hoping we can get it merged sooner than the CLI wrappers being open sourced, otherwise we'll have to wait.
Good news, I was able to get the wrappers working.
A few rnpm Jest tests are failing
Thanks, I'll copy the changes
On Saturday, 30 July 2016, Alexey email@example.com wrote:
1 similar comment
Ok, I decided to disable rnpm tests from running at FB CI for now.
Brace yourselves, this PR is going to be landed now