Nit: Check executionContext === NoContext first

In the common case it will be false and the binary expression will short circuit.
facebook · Mar 16, 2021 · 39ea576 · 39ea576
1 parent 632dede
commit 39ea576
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.new.js b/packages/react-reconciler/src/ReactFiberWorkLoop.new.js
@@ -548,8 +548,8 @@ export function scheduleUpdateOnFiber(
       ensureRootIsScheduled(root, eventTime);
       schedulePendingInteractions(root, lane);
       if (
-        (fiber.mode & ConcurrentMode) === NoMode &&
-        executionContext === NoContext
+        executionContext === NoContext &&
+        (fiber.mode & ConcurrentMode) === NoMode
       ) {
         // Flush the synchronous work now, unless we're already working or inside
         // a batch. This is intentionally inside scheduleUpdateOnFiber instead of

diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.old.js b/packages/react-reconciler/src/ReactFiberWorkLoop.old.js
@@ -548,8 +548,8 @@ export function scheduleUpdateOnFiber(
       ensureRootIsScheduled(root, eventTime);
       schedulePendingInteractions(root, lane);
       if (
-        (fiber.mode & ConcurrentMode) === NoMode &&
-        executionContext === NoContext
+        executionContext === NoContext &&
+        (fiber.mode & ConcurrentMode) === NoMode
       ) {
         // Flush the synchronous work now, unless we're already working or inside
         // a batch. This is intentionally inside scheduleUpdateOnFiber instead of