Allow running download_devtools_regression_build.js on a clean repo
#34456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: 288d428...a82f923 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
commented
Sep 10, 2025
| } | ||
| await downloadRegressionBuild(); | ||
| } catch (e) { | ||
| console.log(chalk.red(e)); |
There was a problem hiding this comment.
I found it annoying that this script always exited with a zero exit code. This could make CI fail but I suspect we'd want to know about these failures. I'm actively working on fixing the regression test suite so I'll notice if this reveals some other issue.
eps1lon
changed the title
download_devtools_regression_build.js on clean repodownload_devtools_regression_build.js on a clean repo
hoxyq
reviewed
Sep 11, 2025
hoxyq
approved these changes
Sep 12, 2025
eps1lon
deleted the
sebbie/09-10-allow_running_download_devtools_regression_build.js_on_clean_repo
branch
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Sep 14, 2025
…facebook#34456) DiffTrain build for [47664de](facebook@47664de)
github-actions bot
pushed a commit
to muditbhadouria/react
that referenced
this pull request
Sep 14, 2025
…facebook#34456) DiffTrain build for [47664de](facebook@47664de)
github-actions bot
pushed a commit
to muditbhadouria/react
that referenced
this pull request
Sep 14, 2025
…facebook#34456) DiffTrain build for [47664de](facebook@47664de)
This was referenced Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version relied on having built something before. These changes make the script work on a fresh clone/worktree. Technically you do need to run
yarn build react-debug-tools react-refresh internal-test-utilsbecause we're not actually doing regression tests for those packages but that's an issue for the tests using those package. The other tests should be able to run on a clean worktree.This is also fixing a bug where we were using the built
react-isnot the published one.Test plan
node ./scripts/ci/download_devtools_regression_build.js 16.0 --replaceBuildon