Skip to content

Allow running download_devtools_regression_build.js on a clean repo #34456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2025
Merged

Allow running download_devtools_regression_build.js on a clean repo #34456

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbf17f7
Allow running `download_devtools_regression_build.js` on clean repo
eps1lon Sep 10, 2025
a843ebd
More accurate regression tests
eps1lon Sep 10, 2025
57fe20b
16.0 compat
eps1lon Sep 10, 2025
a82f923
Update scripts/ci/download_devtools_regression_build.js
eps1lon Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions scripts/ci/download_devtools_regression_build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ const semver = require('semver');
const yargs = require('yargs');
const fs = require('fs');

const INSTALL_PACKAGES = ['react-dom', 'react', 'react-test-renderer'];
const REGRESSION_FOLDER = 'build-regression';

const ROOT_PATH = join(__dirname, '..', '..');
Expand All @@ -23,6 +22,12 @@ const version = process.argv[2];
const shouldReplaceBuild = !!argv.replaceBuild;

async function downloadRegressionBuild() {
const reactVersion = semver.coerce(version).version;
const installPackages = ['react-dom', 'react', 'react-test-renderer'];
if (semver.gte(reactVersion, '16.3.0')) {
installPackages.push('react-is');
}

console.log(chalk.bold.white(`Downloading React v${version}\n`));

// Make build directory for temporary modules we're going to download
Expand All @@ -35,7 +40,7 @@ async function downloadRegressionBuild() {
await exec(`mkdir ${regressionBuildPath}`);

// Install all necessary React packages that have the same version
const downloadPackagesStr = INSTALL_PACKAGES.reduce(
const downloadPackagesStr = installPackages.reduce(
(str, name) => `${str} ${name}@${version}`,
''
);
Expand All @@ -51,7 +56,7 @@ async function downloadRegressionBuild() {

// Remove all the packages that we downloaded in the original build folder
// so we can move the modules from the regression build over
const removePackagesStr = INSTALL_PACKAGES.reduce(
const removePackagesStr = installPackages.reduce(
(str, name) => `${str} ${join(buildPath, name)}`,
''
);
Expand All @@ -63,12 +68,12 @@ async function downloadRegressionBuild() {
.join(' ')}\n`
)
);
await exec(`rm -r ${removePackagesStr}`);
await exec(`rm -rf ${removePackagesStr}`);

// Move all packages that we downloaded to the original build folder
// We need to separately move the scheduler package because it might
// be called schedule
const movePackageString = INSTALL_PACKAGES.reduce(
const movePackageString = installPackages.reduce(
(str, name) => `${str} ${join(regressionBuildPath, 'node_modules', name)}`,
''
);
Expand All @@ -80,9 +85,9 @@ async function downloadRegressionBuild() {
.join(' ')} to ${chalk.underline.blue(buildPath)}\n`
)
);
fs.mkdirSync(buildPath, {recursive: true});
await exec(`mv ${movePackageString} ${buildPath}`);

const reactVersion = semver.coerce(version).version;
// For React versions earlier than 18.0.0, we explicitly scheduler v0.20.1, which
// is the first version that has unstable_mock, which DevTools tests need, but also
// has Scheduler.unstable_trace, which, although we don't use in DevTools tests
Expand All @@ -100,7 +105,7 @@ async function downloadRegressionBuild() {
);
} else {
console.log(chalk.white(`Downloading scheduler\n`));
await exec(`rm -r ${join(buildPath, 'scheduler')}`);
await exec(`rm -rf ${join(buildPath, 'scheduler')}`);
await exec(
`mv ${join(
regressionBuildPath,
Expand Down Expand Up @@ -134,8 +139,6 @@ async function main() {
return;
}
await downloadRegressionBuild();
} catch (e) {
console.log(chalk.red(e));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it annoying that this script always exited with a zero exit code. This could make CI fail but I suspect we'd want to know about these failures. I'm actively working on fixing the regression test suite so I'll notice if this reveals some other issue.

} finally {
// We shouldn't remove the regression-build folder unless we're using
// it to replace the build folder
Expand Down
Loading