Include Fizz runtime diff in CI #34525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
force-pushed
the
sebbie/09-18-include_fizz_runtime_diff_in_ci
branch
from
069a6ca to
b4e7a70
Compare
|
Comparing: 84af908...b4c8d2a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show |
eps1lon
commented
Sep 18, 2025
| - run: | | ||
| yarn generate-inline-fizz-runtime | ||
| git diff --quiet || (echo "There was a change to the Fizz runtime. Run `yarn generate-inline-fizz-runtime` and check in the result." && false) | ||
| git diff --exit-code || (echo "There was a change to the Fizz runtime. Run \`yarn generate-inline-fizz-runtime\` and check in the result." && false) |
There was a problem hiding this comment.
Escaping of backticks is required so that we don't actually run the script. Previously you'd get
There was a change to the Fizz runtime. Run yarn run v1.22.22
$ node ./scripts/rollup/generate-inline-fizz-runtime.js
Done in 7.88s. and check in the result.instead of
There was a change to the Fizz runtime. Run `yarn generate-inline-fizz-runtime` and check in the result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check if the inline Fizz runtime is up-to-date rarely fails but then completes on a retry e.g. https://github.com/facebook/react/actions/runs/17826035222/job/50679328390?pr=34516. We suppressed the diff so it's impossible to tell what the source of the flakiness is.
Now we run without
--quietwhich hopefully gives us a clue. I added--exit-codeso that it still fails on changes.--exit-codewas previously implied by--quiet.Unclear why it was introduced with
--quietin #25481. Probably assuming that running it locally would show you the diff or just c&p from the error codes check.Test plan