Skip to content

Include Fizz runtime diff in CI #34525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2025
+2 −2
Merged

Include Fizz runtime diff in CI #34525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4e7a70
Include Fizz runtime diff in CI
eps1lon Sep 18, 2025
b4c8d2a
Don't actually run the command to update the runtime
eps1lon Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/runtime_build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ jobs:
if: steps.node_modules.outputs.cache-hit != 'true'
- run: |
yarn generate-inline-fizz-runtime
git diff --quiet || (echo "There was a change to the Fizz runtime. Run `yarn generate-inline-fizz-runtime` and check in the result." && false)
git diff --exit-code || (echo "There was a change to the Fizz runtime. Run \`yarn generate-inline-fizz-runtime\` and check in the result." && false)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Escaping of backticks is required so that we don't actually run the script. Previously you'd get

There was a change to the Fizz runtime. Run yarn run v1.22.22
$ node ./scripts/rollup/generate-inline-fizz-runtime.js
Done in 7.88s. and check in the result.

instead of

There was a change to the Fizz runtime. Run `yarn generate-inline-fizz-runtime` and check in the result.


# ----- FEATURE FLAGS -----
flags:
Expand Down Expand Up @@ -567,7 +567,7 @@ jobs:
- name: Search build artifacts for unminified errors
run: |
yarn extract-errors
git diff --quiet || (echo "Found unminified errors. Either update the error codes map or disable error minification for the affected build, if appropriate." && false)
git diff --exit-code || (echo "Found unminified errors. Either update the error codes map or disable error minification for the affected build, if appropriate." && false)

check_release_dependencies:
name: Check release dependencies
Expand Down
Loading