New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use boolean assertion for documentMode check #10032

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
4 participants
@aweary
Member

aweary commented Jun 23, 2017

Resolves #10030

Reverts a small change made in #8575. This should be safe, as we still use this assertion for the change event bubbling check.

cc @flarnie @gaearon this will require another 15.6.x release (not sure if one was planned)

@aweary

This comment has been minimized.

Show comment
Hide comment
@aweary

aweary Jun 23, 2017

Member

This change was already made in master as well: #7594 It just wasn't included in the backport.

Member

aweary commented Jun 23, 2017

This change was already made in master as well: #7594 It just wasn't included in the backport.

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jun 24, 2017

Member

Why does #7594 change two lines but this PR changes one?

Member

gaearon commented Jun 24, 2017

Why does #7594 change two lines but this PR changes one?

@aweary

This comment has been minimized.

Show comment
Hide comment
@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jun 25, 2017

Member

Mind creating an issue linking to everything that's still necessary for 15.6.x? Another one I'm thinking about is CurrentOwner bugfix.

Member

gaearon commented Jun 25, 2017

Mind creating an issue linking to everything that's still necessary for 15.6.x? Another one I'm thinking about is CurrentOwner bugfix.

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jun 26, 2017

Member

Need to run prettier?

Member

gaearon commented Jun 26, 2017

Need to run prettier?

@aweary aweary referenced this pull request Jun 26, 2017

Closed

React 15.6.2 Umbrella #10040

6 of 12 tasks complete
@aweary

This comment has been minimized.

Show comment
Hide comment
@aweary

aweary Jun 26, 2017

Member

@gaearon is the 15.6-dev branch meant to be working with prettier? I did run it locally but it was really out of sync, making the following changes:

	modified:   addons/create-react-class/test.js
	modified:   addons/react-addons-create-fragment/test.js
	modified:   addons/react-addons-linked-state-mixin/test.js
	modified:   addons/react-addons-pure-render-mixin/test.js
	modified:   addons/react-addons-shallow-compare/test.js
	modified:   addons/react-addons-update/test.js
	modified:   addons/react-linked-input/test.js
	modified:   src/renderers/dom/ReactDOM.js
	modified:   src/renderers/dom/client/ReactBrowserEventEmitter.js
	modified:   src/renderers/dom/client/ReactMount.js
	modified:   src/renderers/dom/client/syntheticEvents/SyntheticWheelEvent.js
	modified:   src/renderers/dom/shared/DOMProperty.js
	modified:   src/renderers/dom/shared/ReactComponentBrowserEnvironment.js
	modified:   src/renderers/dom/shared/hooks/ReactDOMUnknownPropertyHook.js
	modified:   src/renderers/native/ReactNative.js
	modified:   src/renderers/native/ReactNativeComponentEnvironment.js
	modified:   src/renderers/shared/ReactDebugTool.js
	modified:   src/renderers/shared/fiber/__tests__/ReactCoroutine-test.js
	modified:   src/renderers/shared/hooks/__tests__/ReactHostOperationHistoryHook-test.js
	modified:   src/renderers/shared/stack/event/eventPlugins/ResponderEventPlugin.js
	modified:   src/renderers/shared/stack/event/eventPlugins/TouchHistoryMath.js
	modified:   src/renderers/shared/stack/event/eventPlugins/__tests__/ResponderEventPlugin-test.js
	modified:   src/renderers/shared/stack/reconciler/ReactOwner.js
	modified:   src/renderers/shared/stack/reconciler/__tests__/ReactIdentity-test.js
	modified:   src/renderers/shared/utils/Transaction.js
	modified:   src/renderers/testing/ReactShallowRenderer.js
	modified:   src/test/ReactTestUtils.js

I can commit these changes (in a separate PR probably) if you'd like @gaearon

Member

aweary commented Jun 26, 2017

@gaearon is the 15.6-dev branch meant to be working with prettier? I did run it locally but it was really out of sync, making the following changes:

	modified:   addons/create-react-class/test.js
	modified:   addons/react-addons-create-fragment/test.js
	modified:   addons/react-addons-linked-state-mixin/test.js
	modified:   addons/react-addons-pure-render-mixin/test.js
	modified:   addons/react-addons-shallow-compare/test.js
	modified:   addons/react-addons-update/test.js
	modified:   addons/react-linked-input/test.js
	modified:   src/renderers/dom/ReactDOM.js
	modified:   src/renderers/dom/client/ReactBrowserEventEmitter.js
	modified:   src/renderers/dom/client/ReactMount.js
	modified:   src/renderers/dom/client/syntheticEvents/SyntheticWheelEvent.js
	modified:   src/renderers/dom/shared/DOMProperty.js
	modified:   src/renderers/dom/shared/ReactComponentBrowserEnvironment.js
	modified:   src/renderers/dom/shared/hooks/ReactDOMUnknownPropertyHook.js
	modified:   src/renderers/native/ReactNative.js
	modified:   src/renderers/native/ReactNativeComponentEnvironment.js
	modified:   src/renderers/shared/ReactDebugTool.js
	modified:   src/renderers/shared/fiber/__tests__/ReactCoroutine-test.js
	modified:   src/renderers/shared/hooks/__tests__/ReactHostOperationHistoryHook-test.js
	modified:   src/renderers/shared/stack/event/eventPlugins/ResponderEventPlugin.js
	modified:   src/renderers/shared/stack/event/eventPlugins/TouchHistoryMath.js
	modified:   src/renderers/shared/stack/event/eventPlugins/__tests__/ResponderEventPlugin-test.js
	modified:   src/renderers/shared/stack/reconciler/ReactOwner.js
	modified:   src/renderers/shared/stack/reconciler/__tests__/ReactIdentity-test.js
	modified:   src/renderers/shared/utils/Transaction.js
	modified:   src/renderers/testing/ReactShallowRenderer.js
	modified:   src/test/ReactTestUtils.js

I can commit these changes (in a separate PR probably) if you'd like @gaearon

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jun 26, 2017

Member

Hmm. It used to work but maybe we're not yet using Yarn there so we need to cherry-pick #10038?

Member

gaearon commented Jun 26, 2017

Hmm. It used to work but maybe we're not yet using Yarn there so we need to cherry-pick #10038?

@aweary

This comment has been minimized.

Show comment
Hide comment
@aweary

aweary Jul 3, 2017

Member

@gaearon cherry-picking #10038 doesn't seem to resolve it.

Member

aweary commented Jul 3, 2017

@gaearon cherry-picking #10038 doesn't seem to resolve it.

@nhunzaker

This comment has been minimized.

Show comment
Hide comment
@nhunzaker

nhunzaker Jul 4, 2017

Collaborator

I think we might have gotten a false positive on the commit where we first ran prettier. I just re-ran the build without cache and it looks like the prettier step failed:

https://circleci.com/gh/facebook/react/4254

It's hard to tell what version of prettier ran - possibly 1.4 - but do you think we just need to run prettier 1.2.2.0 again on 15.6-dev as @aweary suggested?

Collaborator

nhunzaker commented Jul 4, 2017

I think we might have gotten a false positive on the commit where we first ran prettier. I just re-ran the build without cache and it looks like the prettier step failed:

https://circleci.com/gh/facebook/react/4254

It's hard to tell what version of prettier ran - possibly 1.4 - but do you think we just need to run prettier 1.2.2.0 again on 15.6-dev as @aweary suggested?

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jul 11, 2017

Member

I'm cool either way, let's just get the branch to be green.

Member

gaearon commented Jul 11, 2017

I'm cool either way, let's just get the branch to be green.

@aweary aweary referenced this pull request Jul 14, 2017

Merged

Fix uncontrolled radios #10186

@aweary

This comment has been minimized.

Show comment
Hide comment
@aweary

aweary Jul 20, 2017

Member

cc @gaearon @nhunzaker CI is now green 🎉

Member

aweary commented Jul 20, 2017

cc @gaearon @nhunzaker CI is now green 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment