New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit autoFocus={false} attribute on the server #11543

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
4 participants
@gaearon
Member

gaearon commented Nov 13, 2017

Seems like I made a mistake in #11192.
Browsers don't treat autofocus="false" as truthy so we should use HAS_BOOLEAN_VALUE here.

Fixes the issue described in #11192 (comment).

@trueadm

LGTM

@gaearon gaearon merged commit afc5fab into facebook:master Nov 13, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

Ethan-Arrowood added a commit to Ethan-Arrowood/react that referenced this pull request Dec 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment