Remove local getComponentName from ReactPartialRenderer and use shared version #11999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the local getComponentName function from ReactPartialRenderer and uses the one found in shared package.
gaearon
reviewed
Jan 9, 2018
| @@ -187,7 +181,7 @@ function warnNoop( | |||
| if (__DEV__) { | |||
| const constructor = publicInstance.constructor; | |||
| const componentName = | |||
| (constructor && getComponentName(constructor)) || 'ReactClass'; | |||
| (constructor && getComponentName({type: constructor})) || 'ReactClass'; | |||
There was a problem hiding this comment.
This part is kinda hacky and is the reason they weren’t shared. It’s just a different data structure. Maybe it’s reasonable to change the function itself to accept the type directly, but I would rather have duplication than “lie” about the type like here.
There was a problem hiding this comment.
Yes I had the hacky reservation while making the change. I’m open to changing the shared function to just accept the type or I can close this PR. Doesn’t bother me either way, just let me know how you want to proceed.
There was a problem hiding this comment.
Let’s just keep it how it is? I don’t see us changing this function anyway so it’s not worth unifying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the local getComponentName function from ReactPartialRenderer and uses the one found in shared package.
I noticed this while working on #11993. This was the only other
getComponentNamefunction that was defined separately than the shared package.