Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Scheduler - Initial commit #12624

Merged
merged 1 commit into from Apr 19, 2018
Merged

React Scheduler - Initial commit #12624

merged 1 commit into from Apr 19, 2018

Conversation

@flarnie
Copy link
Contributor

@flarnie flarnie commented Apr 16, 2018

This is the first step - pulling the ReactDOMFrameScheduling module out
into a separate package.

Will write more fullly about the movitations for this in follow-up PRs which add the more customized behavior.

@pull-bot
Copy link

@pull-bot pull-bot commented Apr 16, 2018

Details of bundled changes.

Comparing: 5dfbfe9...88afff7

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% +0.1% 609.28 KB 609.76 KB 140.41 KB 140.58 KB UMD_DEV
react-dom.development.js +0.1% +0.1% 593.65 KB 594.14 KB 136.25 KB 136.42 KB NODE_DEV
ReactDOM-dev.js +0.1% +0.1% 618.04 KB 618.53 KB 139.01 KB 139.17 KB FB_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% +0.2% 412.38 KB 412.86 KB 89.46 KB 89.64 KB UMD_DEV
react-art.development.js +0.1% +0.3% 338.21 KB 338.7 KB 70.68 KB 70.86 KB NODE_DEV
ReactART-dev.js +0.1% +0.3% 346.44 KB 346.92 KB 70.26 KB 70.45 KB FB_DEV

react-scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-scheduler.development.js n/a n/a 0 B 12.07 KB 0 B 4.17 KB UMD_DEV
react-scheduler.production.min.js n/a n/a 0 B 1.83 KB 0 B 912 B UMD_PROD
react-scheduler.development.js n/a n/a 0 B 11.88 KB 0 B 4.11 KB NODE_DEV
react-scheduler.production.min.js n/a n/a 0 B 1.91 KB 0 B 927 B NODE_PROD

Generated by 🚫 dangerJS

@aweary
Copy link
Collaborator

@aweary aweary commented Apr 16, 2018

Does this supersede #12253? 👀

@acdlite
Copy link
Member

@acdlite acdlite commented Apr 17, 2018

@aweary Yeah, we decided on a new strategy. Perhaps @flarnie can share credit for this commit? She's copied some of your tests.

@aweary
Copy link
Collaborator

@aweary aweary commented Apr 17, 2018

No credit needed, just wanted to know if I should go ahead and close #12253 now :)

@acdlite
Copy link
Member

@acdlite acdlite commented Apr 17, 2018

Thanks for your work on that!

@aweary
Copy link
Collaborator

@aweary aweary commented Apr 17, 2018

Of course! @flarnie if supporting multiple scheduled callbacks is still a goal 4a5134f might be useful as a starting point. I think it's a ~mostly working implementation.

@flarnie
Copy link
Contributor Author

@flarnie flarnie commented Apr 17, 2018

Thanks @aweary and @acdlite - my bad, should have mentioned to you @aweary that I was picking up this work, and thanks for your original PR. Amending this to share credit.

This is the first step - pulling the ReactDOMFrameScheduling module out
into a separate package.

Co-authored-by: Brandon Dail <aweary@users.noreply.github.com>
@flarnie flarnie force-pushed the reactScheduler branch from 65d22db to 88afff7 Apr 17, 2018
@flarnie flarnie merged commit 999b656 into facebook:master Apr 19, 2018
1 check passed
rhagigi added a commit to rhagigi/react that referenced this issue Apr 19, 2018
This is the first step - pulling the ReactDOMFrameScheduling module out
into a separate package.

Co-authored-by: Brandon Dail <aweary@users.noreply.github.com>
@gaearon gaearon mentioned this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants