Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable timeoutMs argument #19703

Merged
merged 2 commits into from Aug 26, 2020
Merged

Disable timeoutMs argument #19703

merged 2 commits into from Aug 26, 2020

Conversation

@acdlite
Copy link
Member

@acdlite acdlite commented Aug 26, 2020

tl;dr

  • We're removing the timeoutMs argument from useTransition.
  • Transitions will either immediately switch to a skeleton/placeholder view (when loading new content) or wait indefinitely until the data resolves (when refreshing stale content).
  • This commit disables the timeoutMS so that the API has the desired semantics. It doesn't yet update the types or migrate all the test callers. I'll do those steps in follow-up PRs.

Motivation

Currently, transitions initiated by startTransition / useTransition accept a timeoutMs option. You can use this to control the maximum amount of time that a transition is allowed to delay before we give up and show a placeholder.

What we've discovered is that, in practice, every transition falls into one of two categories: a load or a refresh:

  • Loading a new screen: show the next screen as soon as possible, even if the data hasn't finished loading. Use a skeleton/placeholder UI to show progress.
  • Refreshing a screen that's already visible: keep showing the current screen indefinitely, for as long as it takes to load the fresh data, even if the current data is stale. Use a pending state (and maybe a busy indicator) to show progress.

In other words, transitions should either delay indefinitely (for a refresh) or they should show a placeholder instantly (for a load). There's not much use for transitions that are delayed for a small-but-noticeable amount of time.

So, the plan is to remove the timeoutMs option. Instead, we'll assign an effective timeout of 0 for loads, and Infinity for refreshes.

The mechanism for distinguishing a load from a refresh already exists in the current model. If a component suspends, and the nearest Suspense boundary hasn't already mounted, we treat that as a load, because there's nothing on the screen. However, if the nearest boundary is mounted, we treat that as a refresh, since it's already showing content.

If you need to fix a transition to be treated as a load instead of a refresh, or vice versa, the solution will involve rearranging the location of your Suspense boundaries. It may also involve adding a key.

We're still working on proper documentation for these patterns. In the meantime, please reach out to us if you run into problems that you're unsure how to fix.

We will remove timeoutMs from useDeferredValue, too, and apply the same load versus refresh semantics to the update that spawns the deferred value.

Note that there are other types of delays that are not related to transitions; for example, we will still throttle the appearance of nested placeholders (we refer to this as the placeholder "train model"), and we may still apply a Just Noticeable Difference heuristic (JND) in some cases. These aren't going anywhere. (Well, the JND heuristic might but for different reasons than those discussed above.)

acdlite added 2 commits Aug 26, 2020
We're removing the `timeoutMs` option, so there's no longer any
distinction between "short" and "long" transitions. They're all treated
the same.

This commit doesn't remove `timeoutMs` yet, only combines the internal
priority levels.
tl;dr
-----

- We're removing the `timeoutMs` argument from `useTransition`.
- Transitions will either immediately switch to a skeleton/placeholder
  view (when loading new content) or wait indefinitely until the data
  resolves (when refreshing stale content).
- This commit disables the `timeoutMS` so that the API has the desired
  semantics. It doesn't yet update the types or migrate all the test
  callers. I'll do those steps in follow-up PRs.

Motivation
----------

Currently, transitions initiated by `startTransition` / `useTransition`
accept a `timeoutMs` option. You can use this to control the maximum
amount of time that a transition is allowed to delay before we give up
and show a placeholder.

What we've discovered is that, in practice, every transition falls into
one of two categories: a **load** or a **refresh**:

- **Loading a new screen**: show the next screen as soon as possible,
  even if the data hasn't finished loading. Use a skeleton/placeholder
  UI to show progress.
- **Refreshing a screen that's already visible**: keep showing the
  current screen indefinitely, for as long as it takes to load the fresh
  data, even if the current data is stale. Use a pending state (and
  maybe a busy indicator) to show progress.

In other words, transitions should either *delay indefinitely* (for a
refresh) or they should show a placeholder *instantly* (for a load).
There's not much use for transitions that are delayed for a
small-but-noticeable amount of time.

So, the plan is to remove the `timeoutMs` option. Instead, we'll assign
an effective timeout of `0` for loads, and `Infinity` for refreshes.

The mechanism for distinguishing a load from a refresh already exists in
the current model. If a component suspends, and the nearest Suspense
boundary hasn't already mounted, we treat that as a load, because
there's nothing on the screen. However, if the nearest boundary is
mounted, we treat that as a refresh, since it's already showing content.

If you need to fix a transition to be treated as a load instead of a
refresh, or vice versa, the solution will involve rearranging the
location of your Suspense boundaries. It may also involve adding a key.

We're still working on proper documentation for these patterns. In the
meantime, please reach out to us if you run into problems that you're
unsure how to fix.

We will remove `timeoutMs` from `useDeferredValue`, too, and apply the
same load versus refresh semantics to the update that spawns the
deferred value.

Note that there are other types of delays that are not related to
transitions; for example, we will still throttle the appearance of
nested placeholders (we refer to this as the placeholder "train model"),
and we may still apply a Just Noticeable Difference heuristic (JND) in
some cases. These aren't going anywhere. (Well, the JND heuristic might
but for different reasons than those discussed above.)
@acdlite acdlite changed the title Disable timeoutms Disable timeoutMs argument Aug 26, 2020
@sizebot
Copy link

@sizebot sizebot commented Aug 26, 2020

Details of bundled changes.

Comparing: 60ba723...93ca66a

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.3% -0.1% 917.71 KB 914.66 KB 208.22 KB 207.92 KB NODE_DEV
ReactDOMForked-prod.js -0.3% -0.3% 382.69 KB 381.39 KB 70.71 KB 70.5 KB FB_WWW_PROD
react-dom.production.min.js -0.3% -0.3% 124.4 KB 123.98 KB 39.92 KB 39.8 KB NODE_PROD
ReactDOMForked-profiling.js -0.3% -0.3% 396.06 KB 394.77 KB 73.19 KB 72.99 KB FB_WWW_PROFILING
ReactDOMTesting-dev.js -0.3% -0.2% 925.31 KB 922.17 KB 207.87 KB 207.53 KB FB_WWW_DEV
ReactDOMTesting-prod.js -0.3% -0.3% 381.22 KB 379.92 KB 71.62 KB 71.4 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.52 KB 5.52 KB 1.84 KB 1.84 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 5.25 KB 5.25 KB 1.78 KB 1.78 KB UMD_DEV
react-dom.development.js -0.3% -0.1% 964.14 KB 960.95 KB 210.82 KB 210.52 KB UMD_DEV
react-dom.production.min.js -0.3% -0.3% 124.3 KB 123.88 KB 40.68 KB 40.56 KB UMD_PROD
react-dom.profiling.min.js -0.3% -0.3% 129.56 KB 129.14 KB 42.3 KB 42.2 KB UMD_PROFILING
ReactDOMForked-dev.js -0.3% -0.2% 968.62 KB 965.48 KB 215.33 KB 214.99 KB FB_WWW_DEV
react-dom.profiling.min.js -0.3% -0.3% 129.85 KB 129.43 KB 41.54 KB 41.41 KB NODE_PROFILING
ReactDOM-dev.js -0.3% -0.2% 967.85 KB 964.71 KB 215.93 KB 215.61 KB FB_WWW_DEV
ReactDOM-prod.js -0.3% -0.3% 382.23 KB 380.92 KB 70.47 KB 70.27 KB FB_WWW_PROD
ReactDOM-profiling.js -0.3% -0.3% 395.31 KB 394.01 KB 72.89 KB 72.7 KB FB_WWW_PROFILING
react-dom-test-utils.development.js 0.0% 0.0% 66.1 KB 66.1 KB 18.24 KB 18.24 KB UMD_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js -0.5% -0.5% 238.48 KB 237.18 KB 41.99 KB 41.78 KB FB_WWW_PROD
react-art.development.js -0.5% -0.2% 695.26 KB 692.07 KB 147.18 KB 146.93 KB UMD_DEV
react-art.production.min.js -0.4% -0.4% 112.81 KB 112.39 KB 34.97 KB 34.83 KB UMD_PROD
react-art.development.js -0.5% -0.2% 596.36 KB 593.3 KB 129.34 KB 129.06 KB NODE_DEV
react-art.production.min.js -0.5% -0.5% 77.69 KB 77.27 KB 24.05 KB 23.94 KB NODE_PROD
ReactART-dev.js -0.5% -0.2% 623.13 KB 619.98 KB 132.22 KB 131.93 KB FB_WWW_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js -0.5% -0.2% 654.88 KB 651.82 KB 139.62 KB 139.3 KB NODE_DEV
react-reconciler.production.min.js -0.5% -0.5% 87.68 KB 87.27 KB 26.91 KB 26.78 KB NODE_PROD
react-reconciler.profiling.min.js -0.4% -0.4% 93.11 KB 92.69 KB 28.54 KB 28.43 KB NODE_PROFILING

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -0.5% -0.2% 606.65 KB 603.63 KB 127.44 KB 127.18 KB UMD_DEV
react-test-renderer.production.min.js -0.5% -0.6% 77.01 KB 76.62 KB 24.16 KB 24.01 KB UMD_PROD
react-test-renderer.development.js -0.5% -0.2% 578.03 KB 575.13 KB 126 KB 125.72 KB NODE_DEV
react-test-renderer.production.min.js -0.5% -0.5% 76.8 KB 76.41 KB 23.83 KB 23.72 KB NODE_PROD
ReactTestRenderer-dev.js -0.5% -0.2% 593.17 KB 590.19 KB 127.17 KB 126.87 KB FB_WWW_DEV
ReactTestRenderer-dev.js -0.5% -0.2% 587.81 KB 584.85 KB 126.92 KB 126.63 KB RN_FB_DEV
ReactTestRenderer-prod.js -0.5% -0.5% 232.72 KB 231.48 KB 42.24 KB 42.03 KB RN_FB_PROD
ReactTestRenderer-profiling.js -0.5% -0.5% 244.06 KB 242.82 KB 44.4 KB 44.19 KB RN_FB_PROFILING

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.4% -0.2% 681.11 KB 678.16 KB 147.74 KB 147.45 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.5% -0.4% 273.52 KB 272.27 KB 48.63 KB 48.42 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.4% -0.4% 284.98 KB 283.73 KB 50.82 KB 50.61 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.4% -0.2% 661.75 KB 658.79 KB 143.07 KB 142.77 KB RN_OSS_DEV
ReactFabric-prod.js -0.5% -0.4% 267.19 KB 265.94 KB 47.33 KB 47.11 KB RN_OSS_PROD
ReactFabric-profiling.js -0.4% -0.4% 278.74 KB 277.49 KB 49.52 KB 49.32 KB RN_OSS_PROFILING

Size changes (experimental)

Generated by 🚫 dangerJS against 93ca66a

@sizebot
Copy link

@sizebot sizebot commented Aug 26, 2020

Details of bundled changes.

Comparing: 60ba723...93ca66a

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.3% -0.2% 881.96 KB 879.07 KB 201.71 KB 201.39 KB NODE_DEV
ReactDOMForked-prod.js -0.3% -0.3% 393.85 KB 392.55 KB 72.44 KB 72.24 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 137.08 KB 137.08 KB 36.38 KB 36.38 KB NODE_DEV
react-dom.production.min.js -0.3% -0.3% 119.78 KB 119.39 KB 38.56 KB 38.44 KB NODE_PROD
ReactDOMForked-profiling.js -0.3% -0.3% 407.28 KB 405.98 KB 74.94 KB 74.74 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 143.16 KB 143.16 KB 36.58 KB 36.58 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.2 KB 20.2 KB 7.58 KB 7.58 KB NODE_PROD
ReactDOMTesting-dev.js -0.3% -0.2% 953.39 KB 950.25 KB 213.36 KB 213 KB FB_WWW_DEV
ReactDOMTesting-prod.js -0.3% -0.3% 393.86 KB 392.57 KB 73.69 KB 73.46 KB FB_WWW_PROD
react-dom.development.js -0.3% -0.1% 926.63 KB 923.61 KB 204.19 KB 203.89 KB UMD_DEV
react-dom.production.min.js -0.3% -0.3% 119.74 KB 119.36 KB 39.27 KB 39.17 KB UMD_PROD
react-dom.profiling.min.js -0.3% -0.3% 123.65 KB 123.26 KB 40.5 KB 40.37 KB UMD_PROFILING
ReactDOMForked-dev.js -0.3% -0.2% 994.14 KB 991 KB 220.13 KB 219.79 KB FB_WWW_DEV
react-dom.profiling.min.js -0.3% -0.3% 123.85 KB 123.47 KB 39.81 KB 39.7 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.88 KB 19.88 KB 7.46 KB 7.46 KB UMD_PROD
ReactDOM-dev.js -0.3% -0.1% 993.37 KB 990.23 KB 220.69 KB 220.36 KB FB_WWW_DEV
ReactDOM-prod.js -0.3% -0.3% 393.39 KB 392.09 KB 72.2 KB 71.98 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 135.81 KB 135.81 KB 36.13 KB 36.13 KB NODE_DEV
ReactDOM-profiling.js -0.3% -0.2% 406.52 KB 405.22 KB 74.6 KB 74.41 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.78 KB 19.78 KB 7.42 KB 7.42 KB NODE_PROD
ReactDOMServer-dev.js 0.0% -0.0% 145.61 KB 145.61 KB 37.32 KB 37.32 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 47.3 KB 47.3 KB 11.04 KB 11.04 KB FB_WWW_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js -0.5% -0.5% 245.62 KB 244.34 KB 43.25 KB 43.05 KB FB_WWW_PROD
react-art.development.js -0.5% -0.2% 668.15 KB 665.13 KB 142.16 KB 141.92 KB UMD_DEV
react-art.production.min.js -0.4% -0.4% 109.84 KB 109.45 KB 34.08 KB 33.94 KB UMD_PROD
react-art.development.js -0.5% -0.2% 570.52 KB 567.62 KB 124.44 KB 124.17 KB NODE_DEV
react-art.production.min.js -0.5% -0.5% 74.78 KB 74.39 KB 23.19 KB 23.09 KB NODE_PROD
ReactART-dev.js -0.5% -0.2% 633.14 KB 629.99 KB 134.25 KB 133.95 KB FB_WWW_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.4% -0.2% 686.5 KB 683.54 KB 148.59 KB 148.3 KB RN_FB_DEV
ReactFabric-dev.js -0.4% -0.2% 667.14 KB 664.18 KB 143.93 KB 143.63 KB RN_FB_DEV
ReactNativeRenderer-dev.js -0.4% -0.2% 681.1 KB 678.14 KB 147.73 KB 147.44 KB RN_OSS_DEV
ReactFabric-prod.js -0.5% -0.5% 267.15 KB 265.89 KB 47.3 KB 47.09 KB RN_FB_PROD
ReactNativeRenderer-prod.js -0.5% -0.4% 273.51 KB 272.26 KB 48.62 KB 48.41 KB RN_OSS_PROD
ReactFabric-profiling.js -0.4% -0.4% 278.68 KB 277.44 KB 49.5 KB 49.29 KB RN_FB_PROFILING
ReactNativeRenderer-profiling.js -0.4% -0.4% 284.96 KB 283.72 KB 50.81 KB 50.6 KB RN_OSS_PROFILING
ReactNativeRenderer-prod.js -0.5% -0.4% 273.46 KB 272.22 KB 48.6 KB 48.4 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.4% -0.4% 284.92 KB 283.67 KB 50.79 KB 50.58 KB RN_FB_PROFILING
ReactFabric-dev.js -0.4% -0.2% 661.73 KB 658.77 KB 143.06 KB 142.76 KB RN_OSS_DEV
ReactFabric-prod.js -0.5% -0.4% 267.18 KB 265.93 KB 47.32 KB 47.1 KB RN_OSS_PROD
ReactFabric-profiling.js -0.4% -0.4% 278.72 KB 277.48 KB 49.52 KB 49.31 KB RN_OSS_PROFILING

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js -0.5% -0.2% 626.56 KB 623.66 KB 134.13 KB 133.83 KB NODE_DEV
react-reconciler.production.min.js -0.5% -0.4% 84.33 KB 83.95 KB 25.97 KB 25.85 KB NODE_PROD
react-reconciler.profiling.min.js -0.4% -0.4% 88.38 KB 87.99 KB 27.19 KB 27.08 KB NODE_PROFILING

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -0.5% -0.2% 606.62 KB 603.6 KB 127.42 KB 127.16 KB UMD_DEV
react-test-renderer.production.min.js -0.5% -0.6% 76.99 KB 76.59 KB 24.14 KB 24 KB UMD_PROD
react-test-renderer.development.js -0.5% -0.2% 578 KB 575.11 KB 125.98 KB 125.71 KB NODE_DEV
react-test-renderer.production.min.js -0.5% -0.5% 76.77 KB 76.39 KB 23.81 KB 23.7 KB NODE_PROD
ReactTestRenderer-dev.js -0.5% -0.2% 593.16 KB 590.18 KB 127.16 KB 126.86 KB FB_WWW_DEV
ReactTestRenderer-dev.js -0.5% -0.2% 587.79 KB 584.84 KB 126.91 KB 126.62 KB RN_FB_DEV
ReactTestRenderer-prod.js -0.5% -0.5% 232.71 KB 231.47 KB 42.23 KB 42.02 KB RN_FB_PROD
ReactTestRenderer-profiling.js -0.5% -0.5% 244.05 KB 242.8 KB 44.39 KB 44.18 KB RN_FB_PROFILING

Size changes (stable)

Generated by 🚫 dangerJS against 93ca66a

@codesandbox
Copy link

@codesandbox codesandbox bot commented Aug 26, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 93ca66a:

Sandbox Source
React Configuration
@acdlite acdlite force-pushed the acdlite:disable-timeoutms branch 3 times, most recently from 12efd27 to 93ca66a Aug 26, 2020
@acdlite acdlite requested a review from rickhanlonii Aug 26, 2020
@acdlite acdlite marked this pull request as ready for review Aug 26, 2020
Copy link
Member

@rickhanlonii rickhanlonii left a comment

LGTM

});
// Later we load the data.
Scheduler.unstable_advanceTime(3000);
await advanceTimers(3000);
await resolveText('B');

This comment has been minimized.

@rickhanlonii

rickhanlonii Aug 26, 2020
Member

Nice, I was just thinking we should refactor this so resolving the data doesn't require timers.

<span hidden={true} prop="B" />
<span prop="Loading..." />
</>,
);

This comment has been minimized.

@rickhanlonii

rickhanlonii Aug 26, 2020
Member

Why was this test ending with a placeholder before instead or resolving the values like we do now?

This comment has been minimized.

@acdlite

acdlite Aug 26, 2020
Author Member

This is a regression test that, at the time, triggered a very specific bug in the implementation. It's not really possible to trigger the exact scenario anymore because the semantics of placeholders have changed. But I generally like to keep around old regression tests because they cover cases that we often wouldn't think to write tests for otherwise. It's not uncommon for them to catch things during refactors, even when the initial bug is no longer relevant.

This comment has been minimized.

@rickhanlonii

rickhanlonii Aug 27, 2020
Member

I guess what I'm asking is do you know why it stopped with rendering a fallback?

Was that that regression we were testing?

@@ -4030,9 +3997,6 @@ describe('ReactSuspenseWithNoopRenderer', () => {
// Neither is resolved yet.
'Pending...',
'',
'Pending...',
'Suspend! [a]',

This comment has been minimized.

@rickhanlonii

rickhanlonii Aug 26, 2020
Member

How was [a] suspending again before and why isn't it now?

This comment has been minimized.

@acdlite

acdlite Aug 26, 2020
Author Member

A used to be categorized as TransitionShortPriority and B was TransitionLongPriority. Now they're both just TransitionPriority and so get batched together. This will change again once we implement parallel transitions.

This comment has been minimized.

@rickhanlonii

rickhanlonii Aug 27, 2020
Member

I see, would it help to update the comment here to say:

// Neither is resolved yet, but they're batched so we only see the B suspend flushed.

const TransitionLongHydrationLane: Lane = /* */ 0b0000000000000100000000000000000;
const TransitionLongLanes: Lanes = /* */ 0b0000000001111000000000000000000;
const TransitionHydrationLane: Lane = /* */ 0b0000000000000000001000000000000;

This comment has been minimized.

@rickhanlonii

rickhanlonii Aug 26, 2020
Member

Is the hydration lane used for loads or is it used for something else?

This comment has been minimized.

@acdlite

acdlite Aug 26, 2020
Author Member

Hydration lanes are a used for this scenario:

  • During progressive hydration, only part of the initial HTML has been hydrated. Let's say a parent is hydrated, but its child has not.
  • Then, the parent receives an update (setState) and attempts to re-render the child. But the child hasn't even hydrated yet; it's still just showing the initial HTML.
  • We could render a brand new child using the newest props, but that would require discarding the initial HTML and losing its state, like text input.
  • So instead we do a clever thing: pause the parent update, then bump the priority of hydrating the child to a slightly higher priority.
  • Finish hydrating the child. It has now fully mounted.
  • Now try the parent update again and proceed like normal.

In order for the "bump the priority" trick to work, we reserve special lanes that sit in between the ranges used for regular updates. The hydration lanes only ever include this type of work, so that they don't get accidentally batched together with other updates.

This comment has been minimized.

@acdlite

acdlite Aug 26, 2020
Author Member

See:

it('blocks updates to hydrate the content first if props have changed', async () => {
let suspend = false;
let resolve;
const promise = new Promise(resolvePromise => (resolve = resolvePromise));
const ref = React.createRef();
function Child({text}) {
if (suspend) {
throw promise;
} else {
return text;
}
}
function App({text, className}) {
return (
<div>
<Suspense fallback="Loading...">
<span ref={ref} className={className}>
<Child text={text} />
</span>
</Suspense>
</div>
);
}
suspend = false;
const finalHTML = ReactDOMServer.renderToString(
<App text="Hello" className="hello" />,
);
const container = document.createElement('div');
container.innerHTML = finalHTML;
const span = container.getElementsByTagName('span')[0];
// On the client we don't have all data yet but we want to start
// hydrating anyway.
suspend = true;
const root = ReactDOM.createRoot(container, {hydrate: true});
root.render(<App text="Hello" className="hello" />);
Scheduler.unstable_flushAll();
jest.runAllTimers();
expect(ref.current).toBe(null);
expect(span.textContent).toBe('Hello');
// Render an update, which will be higher or the same priority as pinging the hydration.
root.render(<App text="Hi" className="hi" />);
// At the same time, resolving the promise so that rendering can complete.
suspend = false;
resolve();
await promise;
// This should first complete the hydration and then flush the update onto the hydrated state.
Scheduler.unstable_flushAll();
jest.runAllTimers();
// The new span should be the same since we should have successfully hydrated
// before changing it.
const newSpan = container.getElementsByTagName('span')[0];
expect(span).toBe(newSpan);
// We should now have fully rendered with a ref on the new span.
expect(ref.current).toBe(span);
expect(span.textContent).toBe('Hi');
// If we ended up hydrating the existing content, we won't have properly
// patched up the tree, which might mean we haven't patched the className.
expect(span.className).toBe('hi');
});

This comment has been minimized.

@rickhanlonii

rickhanlonii Aug 27, 2020
Member

Awesome, that makes sense. Is it possible (semantically or structurally) for hydration lanes to get entangled with non-hydration lanes?

This comment has been minimized.

@acdlite

acdlite Aug 29, 2020
Author Member

I think theoretically it could happen with useMutableSource, which uses entanglement to de-opt and prevent tearing in some cases when it detects a mutation.

@acdlite acdlite merged commit 8da0da0 into facebook:master Aug 26, 2020
32 checks passed
32 checks passed
Facebook CLA Check Contributor License Agreement is valid!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_build Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_lint_build Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_build Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_persistent Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod_www Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod_www_variant Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_www Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_www_variant Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: sizebot_stable Your tests passed on CircleCI!
Details
ci/circleci: yarn_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_flow Your tests passed on CircleCI!
Details
ci/circleci: yarn_lint Your tests passed on CircleCI!
Details
ci/circleci: yarn_lint_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_test Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build_devtools Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_prod Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_prod_www Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_prod_www_variant Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_www Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_www_variant Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
@kentcdodds
Copy link
Contributor

@kentcdodds kentcdodds commented Aug 28, 2020

please reach out to us if you run into problems that you're unsure how to fix.

Thanks for the invitation 😄 It's very possible I'm missing something, so I apologize if that's the case.

My first thought about this is: what about a scenario where the data takes 100ms to resolve (for a refresh). If pending is set to true instantly then we'll see a flash of loading state. We can solve this by applying a class name and a delayed opacity transition (for example). However, let's assume we do that with a 250ms delay and now the data takes 350ms to resolve. We've just moved the problem from people with fast connections to those with mediocre connections.

So before this change, the way I solved that was using the (currently undocumented and I only think I know how they work) busyDelayMs and busyMinDurationMs options to basically say: "If the transition takes ${busyDelayMs}ms, then make it take at least ${busyMinDurationMs}ms".

I guess that if those options are still available then this should work ok, but this PR #19719 makes it sound like all config has been removed.

So my main question is, what's the (experimental but current) recommended approach to avoiding a flash of loading state given the changes?

In case it's helpful, here's how I explain it when I teach it to others: https://react-suspense.netlify.app/3 (Please, keep in mind that before people pay for or go through this material it is made extremely clear that concurrent mode is experimental and likely to change...).

@gaearon
Copy link
Member

@gaearon gaearon commented Aug 29, 2020

So my main question is, what's the (experimental but current) recommended approach to avoiding a flash of loading state given the changes?

My understanding is that there is currently none. In the longer term, this is something we want to support in principle, but with a different API. In the short term, not supporting this seems like already the status quo before Concurrent Mode — so it's something you have to accept (or work around in userland) regardless.

@acdlite
Copy link
Member Author

@acdlite acdlite commented Aug 29, 2020

Longer term the hope is to build a first-class API for enter/leave animations. Like ReactTransitionGroup, but way better.

So yeah, we're kicking the can down the road a bit.

@kentcdodds
Copy link
Contributor

@kentcdodds kentcdodds commented Aug 29, 2020

I can accept that 🙂 thanks!

@jeremy-deutsch
Copy link

@jeremy-deutsch jeremy-deutsch commented Aug 30, 2020

Drive-by curiosity question:

Since “suspending on a user-blocking update” doesn’t seem to be an issue anymore, what’s the practical difference now between wrapping a setState call in a startTransition vs not wrapping it in startTransition, in the case that the state change triggers a not-yet-mounted Suspense boundary (aka effective timeoutMs of 0)?

(It’s cool if the answer is just “we’ll talk about that in the docs when we release”)

facebook-github-bot added a commit to facebook/react-native that referenced this pull request Oct 27, 2020
Summary:
This sync includes the following changes:
- **[eaaf4cbce](facebook/react@eaaf4cb )**: 17.0.1 //<Dan Abramov>//
- **[6f62abb58](facebook/react@6f62abb )**: Remove usage of Array#fill ([#20071](facebook/react#20071)) //<Dan Abramov>//
- **[40cfe1f48](facebook/react@40cfe1f )**: Update CHANGELOG.md //<Dan Abramov>//
- **[f021a983a](facebook/react@f021a98 )**: Bump versions for 17 ([#20062](facebook/react#20062)) //<Dan Abramov>//
- **[d1bb4d851](facebook/react@d1bb4d8 )**: Profiler: Include ref callbacks in onCommit duration ([#20060](facebook/react#20060)) //<Brian Vaughn>//
- **[c59c3dfe5](facebook/react@c59c3df )**: useRef: Warn about reading or writing mutable values during render ([#18545](facebook/react#18545)) //<Brian Vaughn>//
- **[7b6cac952](facebook/react@7b6cac9 )**: Improved Profiler commit hooks test ([#20053](facebook/react#20053)) //<Brian Vaughn>//
- **[dfb6a4033](facebook/react@dfb6a40 )**: [Fast Refresh] Fix crashes caused by rogue Proxies ([#20030](facebook/react#20030)) ([#20039](facebook/react#20039)) //<Kai Riemann>//
- **[37cb732c5](facebook/react@37cb732 )**: Use bitwise OR to define flag masks ([#20044](facebook/react#20044)) //<Andrew Clark>//
- **[eb3181e77](facebook/react@eb3181e )**: Add Visibility flag for hiding/unhiding trees ([#20043](facebook/react#20043)) //<Andrew Clark>//
- **[0dd809bdf](facebook/react@0dd809b )**: Remove last schedulePassiveEffectCallback call ([#20042](facebook/react#20042)) //<Andrew Clark>//
- **[8df7b7911](facebook/react@8df7b79 )**: Remove Passive flag from "before mutation" phase ([#20038](facebook/react#20038)) //<Andrew Clark>//
- **[c57fe4a2c](facebook/react@c57fe4a )**: ReactIs.isValidElementType Unit Test extended with PureComponent case ([#20033](facebook/react#20033)) //<adasq>//
- **[02da938fd](facebook/react@02da938 )**: Don't double-invoke effects in legacy roots ([#20028](facebook/react#20028)) //<Brian Vaughn>//
- **[d95c4938d](facebook/react@d95c493 )**: [EventSystem] Revise onBeforeBlur propagation mechanics ([#20020](facebook/react#20020)) //<Dominic Gannaway>//
- **[f46a80ae1](facebook/react@f46a80a )**: Update outdated links and fix two broken links  ([#19985](facebook/react#19985)) //<Saikat Guha>//
- **[0a4c7c565](facebook/react@0a4c7c5 )**: [Flight] Don't warn for key, but error for ref ([#19986](facebook/react#19986)) //<Sebastian Markbåge>//
- **[993ca533b](facebook/react@993ca53 )**: Enable eager listeners statically ([#19983](facebook/react#19983)) //<Dan Abramov>//
- **[40c52de96](facebook/react@40c52de )**: [Flight] Add Runtime Errors for Non-serializable Values ([#19980](facebook/react#19980)) //<Sebastian Markbåge>//
- **[1992d9730](facebook/react@1992d97 )**: Revert "Temporarily disable Profiler commit hooks flag ([#19900](facebook/react#19900))" ([#19960](facebook/react#19960)) //<Brian Vaughn>//
- **[44d39c4d7](facebook/react@44d39c4 )**: Removed skip-error-boundaries modifications from old fork ([#19961](facebook/react#19961)) //<Brian Vaughn>//
- **[cc77be957](facebook/react@cc77be9 )**: Remove unnecessary error overriding in ([#19949](facebook/react#19949)) //<Paul Doyle>//
- **[97625272a](facebook/react@9762527 )**: Debug tracing tests for CPU bound suspense ([#19943](facebook/react#19943)) //<Brian Vaughn>//
- **[43363e279](facebook/react@43363e2 )**: Fix codestyle for typeof comparison ([#19928](facebook/react#19928)) //<Eugene Maslovich>//
- **[5427b4657](facebook/react@5427b46 )**: Temporarily disable Profiler commit hooks flag ([#19900](facebook/react#19900)) //<Brian Vaughn>//
- **[1faf9e3dd](facebook/react@1faf9e3 )**: Suspense for CPU-bound trees ([#19936](facebook/react#19936)) //<Andrew Clark>//
- **[7f08e908b](facebook/react@7f08e90 )**: Fix missing context to componentDidMount() when double-invoking lifecycles ([#19935](facebook/react#19935)) //<Brian Vaughn>//
- **[9198a5cec](facebook/react@9198a5c )**: Refactor layout effect methods ([#19895](facebook/react#19895)) //<Brian Vaughn>//
- **[ba82eea38](facebook/react@ba82eea )**: Remove disableSchedulerTimeoutInWorkLoop flag ([#19902](facebook/react#19902)) //<Andrew Clark>//
- **[c63741fb3](facebook/react@c63741f )**: offscreen double invoke effects ([#19523](facebook/react#19523)) //<Luna Ruan>//
- **[c6917346f](facebook/react@c691734 )**: Fixed broken Profiler test ([#19894](facebook/react#19894)) //<Brian Vaughn>//
- **[87c023b1c](facebook/react@87c023b )**: Profiler onRender only called when we do work ([#19885](facebook/react#19885)) //<Brian Vaughn>//
- **[81aaee56a](facebook/react@81aaee5 )**: Don't call onCommit et al if there are no effects ([#19863](facebook/react#19863)) //<Andrew Clark>//
- **[7355bf575](facebook/react@7355bf5 )**: Consolidate commit phase hook functions ([#19864](facebook/react#19864)) //<Andrew Clark>//
- **[bc6b7b6b1](facebook/react@bc6b7b6 )**: Don't trigger lazy in DEV during element creation ([#19871](facebook/react#19871)) //<Dan Abramov>//
- **[a774502e0](facebook/react@a774502 )**: Use single quotes in getComponentName return ([#19873](facebook/react#19873)) //<Gustavo Saiani>//
- **[8b2d3783e](facebook/react@8b2d378 )**: Use Passive flag to schedule onPostCommit ([#19862](facebook/react#19862)) //<Andrew Clark>//
- **[50d9451f3](facebook/react@50d9451 )**: Improve DevTools editing interface ([#19774](facebook/react#19774)) //<Brian Vaughn>//
- **[6fddca27e](facebook/react@6fddca2 )**: Remove passive intervention flag ([#19849](facebook/react#19849)) //<Dan Abramov>//
- **[36df9185c](facebook/react@36df918 )**: chore(docs): Removed outdated comment about fb.me link  ([#19830](facebook/react#19830)) //<Adnaan Bheda>//
- **[16fb2b6f9](facebook/react@16fb2b6 )**: Moved resetChildLanes into complete work ([#19836](facebook/react#19836)) //<Brian Vaughn>//
- **[cc581065d](facebook/react@cc58106 )**: eslint-plugin-react-hooks@4.1.2 //<Dan Abramov>//
- **[0044805c8](facebook/react@0044805 )**: Update CHANGELOG.md //<Dan Abramov>//
- **[0f70d4dd6](facebook/react@0f70d4d )**: Consider components in jsx as missing dependencies in typescript-eslint/parser@4.x ([#19815](facebook/react#19815)) //<Sebastian Silbermann>//
- **[84558c61b](facebook/react@84558c6 )**: Don't visit passive effects during layout phase ([#19809](facebook/react#19809)) //<Andrew Clark>//
- **[ad8a0a8cd](facebook/react@ad8a0a8 )**: eslint-plugin-react-hooks@4.1.1 //<Dan Abramov>//
- **[77544a0d6](facebook/react@77544a0 )**: Update CHANGELOG.md //<Dan Abramov>//
- **[ed4fdfc73](facebook/react@ed4fdfc )**: test(eslint-plugin-react-hooks): Run with TS parsers >= 2.x ([#19792](facebook/react#19792)) //<Sebastian Silbermann>//
- **[cd75f93c0](facebook/react@cd75f93 )**: eslint-plugin-react-hooks: fix compatibility with typescript-eslint/parser@4.0.0+ ([#19751](facebook/react#19751)) //<Matthias Schiffer>//
- **[781212aab](facebook/react@781212a )**: Remove double space in test name ([#19762](facebook/react#19762)) //<Gustavo Saiani>//
- **[e7b255341](facebook/react@e7b2553 )**: Internal `act`: Flush timers at end of scope ([#19788](facebook/react#19788)) //<Andrew Clark>//
- **[d17086c7c](facebook/react@d17086c )**: Decouple public, internal act implementation ([#19745](facebook/react#19745)) //<Andrew Clark>//
- **[d38ec17b1](facebook/react@d38ec17 )**: [Flight] Set dispatcher for duration of performWork() ([#19776](facebook/react#19776)) //<Joseph Savona>//
- **[4f3f7eeb7](facebook/react@4f3f7ee )**: Bugfix: Effect clean up when deleting suspended tree ([#19752](facebook/react#19752)) //<Andrew Clark>//
- **[7baf9d412](facebook/react@7baf9d4 )**: Combine Flags and SubtreeFlags types ([#19775](facebook/react#19775)) //<Andrew Clark>//
- **[166544360](facebook/react@1665443 )**: Rename effect fields ([#19755](facebook/react#19755)) //<Andrew Clark>//
- **[708fa77a7](facebook/react@708fa77 )**: Decrease expiration time of input updates ([#19772](facebook/react#19772)) //<Andrew Clark>//
- **[36df483af](facebook/react@36df483 )**: Add feature flag to disable scheduler timeout in work loop ([#19771](facebook/react#19771)) //<Ricky>//
- **[bcc0aa463](facebook/react@bcc0aa4 )**: Revert "Revert "Remove onScroll bubbling flag ([#19535](facebook/react#19535))" ([#19655](facebook/react#19655))" ([#19761](facebook/react#19761)) //<Dan Abramov>//
- **[99cae887f](facebook/react@99cae88 )**: Add failing test for passive effect cleanup functions and memoized components ([#19750](facebook/react#19750)) //<Brian Vaughn>//
- **[2cfd73c4d](facebook/react@2cfd73c )**: Fix typo in comment (Noticable→Noticeable) ([#19737](facebook/react#19737)) //<Ikko Ashimine>//
- **[53e622ca7](facebook/react@53e622c )**: Fix instances of function declaration after return ([#19733](facebook/react#19733)) //<Bhumij Gupta>//
- **[b7d18c4da](facebook/react@b7d18c4 )**: Support Babel's envName option in React Refresh plugin ([#19009](facebook/react#19009)) //<Kevin Weber>//
- **[1f38dcff6](facebook/react@1f38dcf )**: Remove withSuspenseConfig ([#19724](facebook/react#19724)) //<Andrew Clark>//
- **[1396e4a8f](facebook/react@1396e4a )**: Fixes eslint warning when node type is ChainExpression ([#19680](facebook/react#19680)) //<Pascal Fong Kye>//
- **[a8500be89](facebook/react@a8500be )**: Add `startTransition` as a known stable method ([#19720](facebook/react#19720)) //<Andrew Clark>//
- **[380dc95de](facebook/react@380dc95 )**: Revert "Append text string to <Text> error message ([#19581](facebook/react#19581))" ([#19723](facebook/react#19723)) //<Timothy Yung>//
- **[ddd1faa19](facebook/react@ddd1faa )**: Remove config argument from useTransition ([#19719](facebook/react#19719)) //<Andrew Clark>//
- **[92fcd46cc](facebook/react@92fcd46 )**: Replace SuspenseConfig object with an integer ([#19706](facebook/react#19706)) //<Andrew Clark>//
- **[b754caaaf](facebook/react@b754caa )**: Enable eager listeners in open source ([#19716](facebook/react#19716)) //<Dan Abramov>//
- **[c1ac05215](facebook/react@c1ac052 )**: [Flight] Support more element types and Hooks for Server and Hybrid Components ([#19711](facebook/react#19711)) //<Dan Abramov>//
- **[1eaafc9ad](facebook/react@1eaafc9 )**: Clean up timeoutMs-related implementation details ([#19704](facebook/react#19704)) //<Andrew Clark>//
- **[8da0da093](facebook/react@8da0da0 )**: Disable timeoutMs argument ([#19703](facebook/react#19703)) //<Andrew Clark>//
- **[60ba723bf](facebook/react@60ba723 )**: Add SuspenseList to devTools ([#19684](facebook/react#19684)) //<Ben Pernick>//
- **[5564f2c95](facebook/react@5564f2c )**: Add React.startTransition ([#19696](facebook/react#19696)) //<Ricky>//
- **[c4e0768d7](facebook/react@c4e0768 )**: Remove unused argument from `finishConcurrentRender` ([#19689](facebook/react#19689)) //<inottn>//
- **[848bb2426](facebook/react@848bb24 )**: Attach Listeners Eagerly to Roots and Portal Containers ([#19659](facebook/react#19659)) //<Dan Abramov>//
- **[d2e914ab4](facebook/react@d2e914a )**: Remove remaining references to effect list ([#19673](facebook/react#19673)) //<Andrew Clark>//
- **[d6e433899](facebook/react@d6e4338 )**: Use Global Render Timeout for CPU Suspense ([#19643](facebook/react#19643)) //<Sebastian Markbåge>//
- **[64ddef44c](facebook/react@64ddef4 )**: Revert "Remove onScroll bubbling flag ([#19535](facebook/react#19535))" ([#19655](facebook/react#19655)) //<Dan Abramov>//
- **[dd651df05](facebook/react@dd651df )**: Keep onTouchStart, onTouchMove, and onWheel passive ([#19654](facebook/react#19654)) //<Dan Abramov>//
- **[b8fa09e9e](facebook/react@b8fa09e )**: provide profiling bundle for react-reconciler ([#19559](facebook/react#19559)) //<Julien Gilli>//
- **[23595ff59](facebook/react@23595ff )**: Add missing param to safelyCallDestroy() ([#19638](facebook/react#19638)) //<Brian Vaughn>//
- **[ee409ea3b](facebook/react@ee409ea )**: change destroy to safelyCallDestroy ([#19605](facebook/react#19605)) //<Luna Ruan>//
- **[bcca5a6ca](facebook/react@bcca5a6 )**: Always skip unmounted/unmounting error boundaries ([#19627](facebook/react#19627)) //<Brian Vaughn>//
- **[1a41a196b](facebook/react@1a41a19 )**: Append text string to <Text> error message ([#19581](facebook/react#19581)) //<Timothy Yung>//
- **[e4afb2fdd](facebook/react@e4afb2f )**: eslint-plugin-react-hooks@4.1.0 //<Dan Abramov>//
- **[ced05c46c](facebook/react@ced05c4 )**: Update CHANGELOG.md //<Dan Abramov>//
- **[702fad4b1](facebook/react@702fad4 )**: refactor fb.me redirect link to reactjs.org/link ([#19598](facebook/react#19598)) //<CY Lim>//
- **[49cd77d24](facebook/react@49cd77d )**: fix: leak strict mode with UMD builds ([#19614](facebook/react#19614)) //<Toru Kobayashi>//
- **[ffb749c95](facebook/react@ffb749c )**: Improve error boundary handling for unmounted subtrees ([#19542](facebook/react#19542)) //<Brian Vaughn>//
- **[9b35dd2fc](facebook/react@9b35dd2 )**: Permanently removed component stacks from scheduling profiler data ([#19615](facebook/react#19615)) //<Brian Vaughn>//
- **[3f8115cdd](facebook/react@3f8115c )**: Remove `didTimeout` check from work loop //<Andrew Clark>//
- **[9abc2785c](facebook/react@9abc278 )**: Remove wasteful checks from `shouldYield` //<Andrew Clark>//
- **[1d5e10f70](facebook/react@1d5e10f )**: [eslint-plugin-react-hooks] Report constant constructions ([#19590](facebook/react#19590)) //<Jordan Eldredge>//
- **[dab0854c5](facebook/react@dab0854 )**: Move commit passive unmount/mount to CommitWork ([#19599](facebook/react#19599)) //<Sebastian Markbåge>//
- **[ccb6c3945](facebook/react@ccb6c39 )**: Remove unused argument ([#19600](facebook/react#19600)) //<inottn>//
- **[629125555](facebook/react@6291255 )**: [Scheduler] Re-throw unhandled errors ([#19595](facebook/react#19595)) //<Andrew Clark>//
- **[b8ed6a1aa](facebook/react@b8ed6a1 )**: [Scheduler] Call postTask directly ([#19551](facebook/react#19551)) //<Andrew Clark>//
- **[ce37bfad5](facebook/react@ce37bfa )**: Remove resolutions from test renderer package.json ([#19577](facebook/react#19577)) //<Dan Abramov>//
- **[2704bb537](facebook/react@2704bb5 )**: Add ReactVersion to SchedulingProfiler render scheduled marks ([#19553](facebook/react#19553)) //<Kartik Choudhary>//
- **[0c52e24cb](facebook/react@0c52e24 )**: Support inner component _debugOwner in memo ([#19556](facebook/react#19556)) //<Brian Vaughn>//
- **[0cd9a6de5](facebook/react@0cd9a6d )**: Parallelize Jest in CI ([#19552](facebook/react#19552)) //<Andrew Clark>//
- **[a63893ff3](facebook/react@a63893f )**: Warn about undefined return value for memo and forwardRef ([#19550](facebook/react#19550)) //<Brian Vaughn>//
- **[32ff42868](facebook/react@32ff428 )**: Add feature flag for setting update lane priority ([#19401](facebook/react#19401)) //<Ricky>//
- **[5bdd4c8c6](facebook/react@5bdd4c8 )**: Remove unused argument from call to jest method ([#19546](facebook/react#19546)) //<Gustavo Saiani>//
- **[a5fed98a9](facebook/react@a5fed98 )**: Register more node types that are used later as JSXIdentifiers ([#19514](facebook/react#19514)) //<Mateusz Burzyński>//
- **[f77c7b9d7](facebook/react@f77c7b9 )**: Re-add discrete flushing timeStamp heuristic (behind flag) ([#19540](facebook/react#19540)) //<Dominic Gannaway>//

Changelog: [general] [feature] Upgrade to React 17

Reviewed By: cpojer

Differential Revision: D24491201

fbshipit-source-id: c947da9dcccbd614e9dc58f3339b63e24829aca7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.