Listen to onScroll during hydration #19803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
commented
Sep 10, 2020
| @@ -797,4 +799,108 @@ describe('ReactDOMEventListener', () => { | |||
| document.body.removeChild(container); | |||
| } | |||
| }); | |||
|
|
|||
| it('should subscribe to scroll during updates', () => { | |||
There was a problem hiding this comment.
This wasn't failing previously but I added for completeness.
| }); | ||
|
|
||
| // Regression test. | ||
| it('should subscribe to scroll during hydration', () => { |
There was a problem hiding this comment.
This one fails on master with the eager flag, but passes here.
| @@ -1086,6 +1086,8 @@ export function diffHydratedProperties( | |||
| } | |||
| if (!enableEagerRootListeners) { | |||
| ensureListeningTo(rootContainerElement, propKey, domElement); | |||
| } else if (propKey === 'onScroll') { | |||
| listenToNonDelegatedEvent('scroll', domElement); | |||
There was a problem hiding this comment.
The fix. This mirrors similar branches in two other places in this file.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d6cf12e:
|
ikara5
approved these changes
Sep 10, 2020
trueadm
approved these changes
Sep 10, 2020
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might explain the regression we're seeing with the eager listener flag. Concretely, I missed one of the places where
onScrollevent should be attached (as it doesn't get delegated). I attached it correctly on first render and updates, but I missed the hydration case. This PR fixes it and adds a regression test that previously failed. It also adds a second test for the update case for better coverage (but that one wasn't broken in the first place).