-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved dev experience when DevTools hook is disabled #20208
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cbd376c
Improved dev experience when DevTools hook is disabled
AceTheCreator fb7136d
Improved dev experience when DevTools hook is disabled
AceTheCreator 237286f
Improved dev experience when DevTools hook is disabled
AceTheCreator 46b6692
Improved dev experience when DevTools hook is disabled
AceTheCreator 9cdc308
Improved dev experience when DevTools hook is disabled
AceTheCreator 1d833fa
Improved dev experience when DevTools hook is disabled
AceTheCreator 6115e23
Improved dev experience when DevTools hook is disabled
AceTheCreator 700ca1c
Improved dev experience when DevTools hook is disabled
AceTheCreator a581a3b
Update packages/react-refresh/src/ReactFreshRuntime.js
AceTheCreator 4937155
Actually disable Fast Refresh
bvaughn 8527d9d
Correct name of global hook variable.
bvaughn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the console warning wasn't actually disabling Fast Refresh. Needed to add
return
to prevent the rest of the function from overridinghook
methods.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bvaughn thanks. Skipped my mind.