Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fizz] Implement useOpaqueIdentifier #21260

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Apr 14, 2021

Builds on top of #21257.

The format of useOpaqueIdentifier varies between formats.

We need to track the responseState so that we know which one currently applies to the currently rendering component.

This should ideally be deterministic. Right now it's not, because it's created during render. This means that depending on which order things unsuspend, you get different resulting HTML.

This implements a naive number incrementation for React Native. RN doesn't have a concept of these IDs yet but it could probably use some special encoding in the protocol instead to create native IDs.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 14, 2021
@sizebot
Copy link

sizebot commented Apr 14, 2021

Comparing: dbadfa2...698ce2b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.68 kB 122.68 kB = 39.38 kB 39.38 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.25 kB 129.25 kB = 41.46 kB 41.46 kB
facebook-www/ReactDOM-prod.classic.js = 412.18 kB 412.18 kB = 76.23 kB 76.23 kB
facebook-www/ReactDOM-prod.modern.js = 400.23 kB 400.23 kB = 74.32 kB 74.32 kB
facebook-www/ReactDOMForked-prod.classic.js = 412.18 kB 412.18 kB = 76.23 kB 76.23 kB
oss-experimental/react-server/cjs/react-server.development.js +26.66% 86.30 kB 109.31 kB +28.85% 21.14 kB 27.23 kB
oss-stable/react-server/cjs/react-server.development.js +26.01% 86.30 kB 108.75 kB +28.15% 21.14 kB 27.09 kB
oss-experimental/react-server/cjs/react-server.production.min.js +23.54% 13.69 kB 16.91 kB +22.24% 4.76 kB 5.82 kB
oss-stable/react-server/cjs/react-server.production.min.js +22.64% 13.69 kB 16.79 kB +21.33% 4.76 kB 5.77 kB
oss-experimental/react-dom/umd/react-dom-unstable-fizz.browser.development.js +13.11% 191.48 kB 216.59 kB +14.23% 44.04 kB 50.30 kB
oss-experimental/react-dom/cjs/react-dom-unstable-fizz.node.development.js +13.08% 182.25 kB 206.08 kB +14.23% 43.48 kB 49.66 kB
oss-experimental/react-dom/cjs/react-dom-unstable-fizz.browser.development.js +13.08% 182.30 kB 206.14 kB +14.20% 43.58 kB 49.77 kB
oss-experimental/react-dom/cjs/react-dom-unstable-fizz.browser.production.min.js +11.63% 28.33 kB 31.62 kB +11.58% 9.55 kB 10.66 kB
oss-experimental/react-dom/umd/react-dom-unstable-fizz.browser.production.min.js +11.55% 28.51 kB 31.81 kB +11.57% 9.66 kB 10.77 kB
oss-experimental/react-dom/cjs/react-dom-unstable-fizz.node.production.min.js +11.50% 28.63 kB 31.93 kB +11.41% 9.58 kB 10.68 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server/cjs/react-server.development.js +26.66% 86.30 kB 109.31 kB +28.85% 21.14 kB 27.23 kB
oss-stable/react-server/cjs/react-server.development.js +26.01% 86.30 kB 108.75 kB +28.15% 21.14 kB 27.09 kB
oss-experimental/react-server/cjs/react-server.production.min.js +23.54% 13.69 kB 16.91 kB +22.24% 4.76 kB 5.82 kB
oss-stable/react-server/cjs/react-server.production.min.js +22.64% 13.69 kB 16.79 kB +21.33% 4.76 kB 5.77 kB
oss-experimental/react-dom/umd/react-dom-unstable-fizz.browser.development.js +13.11% 191.48 kB 216.59 kB +14.23% 44.04 kB 50.30 kB
oss-experimental/react-dom/cjs/react-dom-unstable-fizz.node.development.js +13.08% 182.25 kB 206.08 kB +14.23% 43.48 kB 49.66 kB
oss-experimental/react-dom/cjs/react-dom-unstable-fizz.browser.development.js +13.08% 182.30 kB 206.14 kB +14.20% 43.58 kB 49.77 kB
oss-experimental/react-dom/cjs/react-dom-unstable-fizz.browser.production.min.js +11.63% 28.33 kB 31.62 kB +11.58% 9.55 kB 10.66 kB
oss-experimental/react-dom/umd/react-dom-unstable-fizz.browser.production.min.js +11.55% 28.51 kB 31.81 kB +11.57% 9.66 kB 10.77 kB
oss-experimental/react-dom/cjs/react-dom-unstable-fizz.node.production.min.js +11.50% 28.63 kB 31.93 kB +11.41% 9.58 kB 10.68 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-server.production.min.js +1.52% 2.63 kB 2.67 kB +1.34% 1.05 kB 1.06 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-server.production.min.js +1.52% 2.63 kB 2.67 kB +1.34% 1.05 kB 1.06 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-server.development.js +1.39% 5.47 kB 5.54 kB +1.85% 1.56 kB 1.59 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-server.development.js +1.39% 5.47 kB 5.54 kB +1.85% 1.56 kB 1.59 kB

Generated by 🚫 dangerJS against 698ce2b

@sebmarkbage sebmarkbage force-pushed the fizzopaqueid branch 2 times, most recently from dfb7f89 to 698ce2b Compare April 14, 2021 03:42
The format of this ID is specific to the format.
@sebmarkbage sebmarkbage merged commit f4d7a0f into facebook:master Apr 14, 2021
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Apr 20, 2021
Summary:
This sync includes the following changes:
- **[f7cdc8936](facebook/react@f7cdc8936 )**: Also turn off enableSyncDefaultUpdates in RN test renderer ([#21293](facebook/react#21293)) //<Ricky>//
- **[4c9eb2af1](facebook/react@4c9eb2af1 )**: Add dynamic flags to React Native ([#21291](facebook/react#21291)) //<Ricky>//
- **[9eddfbf5a](facebook/react@9eddfbf5a )**: [Fizz] Two More Fixes ([#21288](facebook/react#21288)) //<Sebastian Markbåge>//
- **[11b07597e](facebook/react@11b07597e )**: Fix classes ([#21283](facebook/react#21283)) //<Sebastian Markbåge>//
- **[96d00b9bb](facebook/react@96d00b9bb )**: [Fizz] Random Fixes ([#21277](facebook/react#21277)) //<Sebastian Markbåge>//
- **[81ef53953](facebook/react@81ef53953 )**: Always insert a dummy node with an ID into fallbacks ([#21272](facebook/react#21272)) //<Sebastian Markbåge>//
- **[a4a940d7a](facebook/react@a4a940d7a )**: [Fizz] Add unsupported Portal/Scope components ([#21261](facebook/react#21261)) //<Sebastian Markbåge>//
- **[f4d7a0f1e](facebook/react@f4d7a0f1e )**: Implement useOpaqueIdentifier ([#21260](facebook/react#21260)) //<Sebastian Markbåge>//
- **[dde875dfb](facebook/react@dde875dfb )**: [Fizz] Implement Hooks ([#21257](facebook/react#21257)) //<Sebastian Markbåge>//
- **[a597c2f5d](facebook/react@a597c2f5d )**: [Fizz] Fix reentrancy bug ([#21270](facebook/react#21270)) //<Sebastian Markbåge>//
- **[15e779d92](facebook/react@15e779d92 )**: Reconciler should inject its own version into DevTools hook ([#21268](facebook/react#21268)) //<Brian Vaughn>//
- **[4f76a28c9](facebook/react@4f76a28c9 )**: [Fizz] Implement New Context ([#21255](facebook/react#21255)) //<Sebastian Markbåge>//
- **[82ef450e0](facebook/react@82ef450e0 )**: remove obsolete SharedArrayBuffer ESLint config ([#21259](facebook/react#21259)) //<Henry Q. Dineen>//
- **[dbadfa2c3](facebook/react@dbadfa2c3 )**: [Fizz] Classes Follow Up ([#21253](facebook/react#21253)) //<Sebastian Markbåge>//
- **[686b635b7](facebook/react@686b635b7 )**: Prevent reading canonical property of null ([#21242](facebook/react#21242)) //<Joshua Gross>//
- **[bb88ce95a](facebook/react@bb88ce95a )**: Bugfix: Don't rely on `finishedLanes` for passive effects ([#21233](facebook/react#21233)) //<Andrew Clark>//
- **[343710c92](facebook/react@343710c92 )**: [Fizz] Fragments and Iterable support ([#21228](facebook/react#21228)) //<Sebastian Markbåge>//
- **[933880b45](facebook/react@933880b45 )**: Make time-slicing opt-in ([#21072](facebook/react#21072)) //<Ricky>//
- **[b0407b55f](facebook/react@b0407b55f )**: Support more empty types ([#21225](facebook/react#21225)) //<Sebastian Markbåge>//
- **[39713716a](facebook/react@39713716a )**: Merge isObject branches ([#21226](facebook/react#21226)) //<Sebastian Markbåge>//
- **[8a4a59c72](facebook/react@8a4a59c72 )**: Remove textarea special case from child fiber ([#21222](facebook/react#21222)) //<Sebastian Markbåge>//
- **[dc108b0f5](facebook/react@dc108b0f5 )**: Track which fibers scheduled the current render work ([#15658](facebook/react#15658)) //<Brian Vaughn>//
- **[6ea749170](facebook/react@6ea749170 )**: Fix typo in comment ([#21214](facebook/react#21214)) //<inokawa>//
- **[b38ac13f9](facebook/react@b38ac13f9 )**: DevTools: Add post-commit hook ([#21183](facebook/react#21183)) //<Brian Vaughn>//
- **[b943aeba8](facebook/react@b943aeba8 )**: Fix: Passive effect updates are never sync ([#21215](facebook/react#21215)) //<Andrew Clark>//
- **[d389c54d1](facebook/react@d389c54d1 )**: Offscreen: Use JS stack to track hidden/unhidden subtree state ([#21211](facebook/react#21211)) //<Brian Vaughn>//
- **[c486dc1a4](facebook/react@c486dc1a4 )**: Remove unnecessary processUpdateQueue ([#21199](facebook/react#21199)) //<Sebastian Markbåge>//
- **[cf45a623a](facebook/react@cf45a623a )**: [Fizz] Implement Classes ([#21200](facebook/react#21200)) //<Sebastian Markbåge>//
- **[75c616554](facebook/react@75c616554 )**: Include actual type of `Profiler#id` on type mismatch ([#20306](facebook/react#20306)) //<Sebastian Silbermann>//
- **[1214b302e](facebook/react@1214b302e )**: test: Fix "couldn't locate all inline snapshots" ([#21205](facebook/react#21205)) //<Sebastian Silbermann>//
- **[1a02d2792](facebook/react@1a02d2792 )**: style: delete unused isHost check ([#21203](facebook/react#21203)) //<wangao>//
- **[782f689ca](facebook/react@782f689ca )**: Don't double invoke getDerivedStateFromProps for module pattern ([#21193](facebook/react#21193)) //<Sebastian Markbåge>//
- **[e90c76a65](facebook/react@e90c76a65 )**: Revert "Offscreen: Use JS stack to track hidden/unhidden subtree state" ([#21194](facebook/react#21194)) //<Brian Vaughn>//
- **[1f8583de8](facebook/react@1f8583de8 )**: Offscreen: Use JS stack to track hidden/unhidden subtree state ([#21192](facebook/react#21192)) //<Brian Vaughn>//
- **[ad6e6ec7b](facebook/react@ad6e6ec7b )**: [Fizz] Prepare Recursive Loop for More Types ([#21186](facebook/react#21186)) //<Sebastian Markbåge>//
- **[172e89b4b](facebook/react@172e89b4b )**: Reland Remove redundant initial of isArray ([#21188](facebook/react#21188)) //<Sebastian Markbåge>//
- **[7c1ba2b57](facebook/react@7c1ba2b57 )**: Proposed new Suspense layout effect semantics ([#21079](facebook/react#21079)) //<Brian Vaughn>//
- **[316aa3686](facebook/react@316aa3686 )**: [Scheduler] Fix de-opt caused by out-of-bounds access ([#21147](facebook/react#21147)) //<Andrey Marchenko>//
- **[b4f119cdf](facebook/react@b4f119cdf )**: Revert "Remove redundant initial of isArray ([#21163](facebook/react#21163))" //<Sebastian Markbage>//
- **[c03197063](facebook/react@c03197063 )**: Revert "apply prettier ([#21165](facebook/react#21165))" //<Sebastian Markbage>//
- **[94fd1214d](facebook/react@94fd1214d )**: apply prettier ([#21165](facebook/react#21165)) //<Behnam Mohammadi>//
- **[b130a0f5c](facebook/react@b130a0f5c )**: Remove redundant initial of isArray ([#21163](facebook/react#21163)) //<Behnam Mohammadi>//
- **[2c9fef32d](facebook/react@2c9fef32d )**: Remove redundant initial of hasOwnProperty ([#21134](facebook/react#21134)) //<Behnam Mohammadi>//
- **[1cf9978d8](facebook/react@1cf9978d8 )**: Don't pass internals to callbacks ([#21161](facebook/react#21161)) //<Sebastian Markbåge>//
- **[b9e4c10e9](facebook/react@b9e4c10e9 )**: [Fizz] Implement all the DOM attributes and special cases ([#21153](facebook/react#21153)) //<Sebastian Markbåge>//
- **[f8ef4ff57](facebook/react@f8ef4ff57 )**: Flush discrete passive effects before paint ([#21150](facebook/react#21150)) //<Andrew Clark>//
- **[b48b38af6](facebook/react@b48b38af6 )**: Support nesting of startTransition and flushSync (alt) ([#21149](facebook/react#21149)) //<Sebastian Markbåge>//

Changelog:
[General][Changed] - React Native sync for revisions c9aab1c...f7cdc89

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii

Differential Revision: D27740113

fbshipit-source-id: 6e27204d78e3e16ed205170006cb97c0d6bfa957
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
The format of this ID is specific to the format.
@gaearon gaearon mentioned this pull request Mar 29, 2022
This was referenced May 19, 2024
This was referenced Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants