Skip to content

[release] Don't lookup build-info.json when updating version numbers #32778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

[release] Don't lookup build-info.json when updating version numbers #32778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1628d5
[release] Also split the onlyPackages param
poteto Mar 28, 2025
6c5ca7a
[release] Don't lookup build-info.json when updating version numbers
poteto Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/release/prepare-release-from-npm-commands/parse-params.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ module.exports = () => {
const params = commandLineArgs(paramDefinitions);

splitCommaParams(params.skipPackages);
splitCommaParams(params.onlyPackages);

return params;
};
18 changes: 0 additions & 18 deletions scripts/release/prepare-release-from-npm-commands/update-stable-version-numbers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,20 +114,6 @@ const run = async ({cwd, packages, version, ci}, versionsMap) => {
clear();

if (packages.includes('react')) {
// A separate "React version" is used for the embedded renderer version to support DevTools,
// since it needs to distinguish between different version ranges of React.
// We need to replace it as well as the "next" version number.
const buildInfoPath = join(nodeModulesPath, 'react', 'build-info.json');
const {reactVersion} = await readJson(buildInfoPath);

if (!reactVersion) {
console.error(
theme`{error Unsupported or invalid build metadata in} {path build/node_modules/react/build-info.json}` +
theme`{error . This could indicate that you have specified an outdated "next" version.}`
);
process.exit(1);
}

// We print the diff to the console for review,
// but it can be large so let's also write it to disk.
const diffPath = join(cwd, 'build', 'temp.diff');
Expand All @@ -152,10 +138,6 @@ const run = async ({cwd, packages, version, ci}, versionsMap) => {
while (afterContents.indexOf(version) >= 0) {
afterContents = afterContents.replace(version, newStableVersion);
}
// Replace inline renderer version numbers (e.g. shared/ReactVersion).
while (afterContents.indexOf(reactVersion) >= 0) {
afterContents = afterContents.replace(reactVersion, newStableVersion);
}
Comment on lines -155 to -158
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we pull all the same versions in this command, this 2nd loop is basically a no-op after the first one.

if (beforeContents !== afterContents) {
numFilesModified++;
// Using a relative path for diff helps with the snapshot test
Expand Down
1 change: 1 addition & 0 deletions scripts/release/publish-commands/parse-params.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ const paramDefinitions = [
module.exports = () => {
const params = commandLineArgs(paramDefinitions);
splitCommaParams(params.skipPackages);
splitCommaParams(params.onlyPackages);
splitCommaParams(params.tags);
params.tags.forEach(tag => {
switch (tag) {
Expand Down
Loading