Skip to content

[ci] Fix check_access again #32935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

[ci] Fix check_access again #32935

merged 1 commit into from
Apr 16, 2025
+15 −15

Conversation

poteto
Copy link
Member

@poteto poteto commented Apr 16, 2025 •
edited
Loading

I can see the value being output and set correctly but not sure why it's skipping the 2nd job.

Stack created with Sapling. Best reviewed with ReviewStack.

@poteto
[ci] Fix check_access again
984650c 
I can see the value being output and set correctly but not sure why it's skipping the 2nd job.
@poteto poteto added the React Core Team Opened by a member of the React Core Team label Apr 16, 2025
@react-sizebot
Copy link

Comparing: 95ff37f...984650c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 516.14 kB 516.14 kB = 91.87 kB 91.87 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 621.45 kB 621.45 kB = 110.01 kB 110.00 kB
facebook-www/ReactDOM-prod.classic.js = 654.82 kB 654.82 kB = 115.57 kB 115.57 kB
facebook-www/ReactDOM-prod.modern.js = 645.10 kB 645.10 kB = 114.04 kB 114.04 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 984650c

@poteto poteto mentioned this pull request Apr 16, 2025
Merged
@poteto poteto merged commit 2ddf8ca into main Apr 16, 2025
248 checks passed
@poteto poteto deleted the pr32935 branch April 16, 2025 22:00
poteto added a commit that referenced this pull request Apr 16, 2025
@poteto
[ci] Only label on PR open (#32936)
4a36d3e 
No reason to label it every update, only do it once when it's first
opened.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32936).
* __->__ #32936
* #32935
github-actions bot pushed a commit that referenced this pull request Apr 16, 2025
@poteto
[ci] Fix check_access again (#32935)
0de4809 
I can see the value being output and set correctly but not sure why it's
skipping the 2nd job.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32935).
* #32936
* __->__ #32935

DiffTrain build for [2ddf8ca](2ddf8ca)
github-actions bot pushed a commit that referenced this pull request Apr 16, 2025
@poteto
[ci] Only label on PR open (#32936)
c684ed4 
No reason to label it every update, only do it once when it's first
opened.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32936).
* __->__ #32936
* #32935

DiffTrain build for [4a36d3e](4a36d3e)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Apr 17, 2025
@pull
[ci] Only label on PR open (facebook#32936)
5dc18d4 
No reason to label it every update, only do it once when it's first
opened.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32936).
* __->__ facebook#32936
* facebook#32935

DiffTrain build for [4a36d3e](facebook@4a36d3e)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Apr 17, 2025
@pull
[ci] Only label on PR open (facebook#32936)
78e9b17 
No reason to label it every update, only do it once when it's first
opened.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32936).
* __->__ facebook#32936
* facebook#32935

DiffTrain build for [4a36d3e](facebook@4a36d3e)
@vercel-release-bot vercel-release-bot mentioned this pull request Apr 17, 2025
Merged
eps1lon pushed a commit to vercel/next.js that referenced this pull request Apr 17, 2025
@vercel-release-bot
Upgrade React from b04254fd-20250415 to 4a36d3ea-20250416 (#78297)
2f7b417 
[diff facebook/react@b04254fd...4a36d3ea](facebook/react@b04254f...4a36d3e)

<details>
<summary>React upstream changes</summary>

- facebook/react#32936
- facebook/react#32935
- facebook/react#32932
- facebook/react#32931
- facebook/react#32930
- facebook/react#32929
- facebook/react#32928
- facebook/react#32934
- facebook/react#32933

</details>
feedthejim pushed a commit to vercel/next.js that referenced this pull request May 14, 2025
@vercel-release-bot @feedthejim
Upgrade React from b04254fd-20250415 to 4a36d3ea-20250416 (#78297)
f28eca5 
[diff facebook/react@b04254fd...4a36d3ea](facebook/react@b04254f...4a36d3e)

<details>
<summary>React upstream changes</summary>

- facebook/react#32936
- facebook/react#32935
- facebook/react#32932
- facebook/react#32931
- facebook/react#32930
- facebook/react#32929
- facebook/react#32928
- facebook/react#32934
- facebook/react#32933

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@poteto @react-sizebot @facebook-github-bot