Skip to content

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Sep 16, 2025

When we disabled minification for the backend in #19369, we didn't have sourcemaps. As of #28730 we do so we can minify it again.

Minification isn't just about reducing parsed size but also about reducing runtime overhead via various compiler optimizations. We only use Terser at the moment but should use Closure in the future.

@meta-cla meta-cla bot added the CLA Signed label Sep 16, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Sep 16, 2025
optimization: {
minimize: false,
minimize: !__DEV__,
minimizer: [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same options as in packages/react-devtools-extensions/webpack.config.js. I'll merge these two configs once they're similar enough.

@eps1lon eps1lon requested a review from hoxyq September 16, 2025 20:28
@eps1lon eps1lon marked this pull request as ready for review September 16, 2025 20:28
@eps1lon eps1lon force-pushed the sebbie/09-16-_devtools_minify_backend branch from 2682f93 to 3f701f7 Compare September 17, 2025 07:24
__DEV__: true,
__DEV__,
__PROFILE__: false,
__DEV____DEV__: true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a mistake. react-devtools-extensions/webpack.config.js doesn't define that var either.

@eps1lon eps1lon merged commit 16df13b into facebook:main Sep 17, 2025
241 checks passed
@eps1lon eps1lon deleted the sebbie/09-16-_devtools_minify_backend branch September 17, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants