Skip to content

[DevTools] Show Transition indicator when "suspended by" rows are expanded #34565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2025
Merged

[DevTools] Show Transition indicator when "suspended by" rows are expanded #34565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0b4672
[DevTools] Show Transition indicator when "suspended by" rows are exp…
eps1lon Sep 23, 2025
f84631b
Leave note to follow-up with default transition indicator
eps1lon Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ages/react-devtools-shared/src/devtools/views/Components/InspectedElementSharedStyles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@
display: flex;
}

.CollapsableHeader[data-pending="true"] {
cursor: progress;
}

.CollapsableHeaderIcon {
flex: 0 0 1rem;
margin-left: -0.25rem;
Expand Down
14 changes: 12 additions & 2 deletions packages/react-devtools-shared/src/devtools/views/Components/InspectedElementSuspendedBy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

import {copy} from 'clipboard-js';
import * as React from 'react';
import {useState} from 'react';
import {useState, useTransition} from 'react';
import Button from '../Button';
import ButtonIcon from '../ButtonIcon';
import KeyValue from './KeyValue';
Expand Down Expand Up @@ -101,6 +101,7 @@ function SuspendedByRow({
maxTime,
}: RowProps) {
const [isOpen, setIsOpen] = useState(false);
const [openIsPending, startOpenTransition] = useTransition();
const ioInfo = asyncInfo.awaited;
const name = useInferredName(asyncInfo);
const description = ioInfo.description;
Expand Down Expand Up @@ -144,7 +145,16 @@ function SuspendedByRow({
<div className={styles.CollapsableRow}>
<Button
className={styles.CollapsableHeader}
onClick={() => setIsOpen(prevIsOpen => !prevIsOpen)}
// TODO: May be better to leave to React's default Transition indicator.
// Though no apps implement this option at the moment.
data-pending={openIsPending}
onClick={() => {
startOpenTransition(() => {
setIsOpen(prevIsOpen => !prevIsOpen);
});
}}
// Changing the title on pending transition will not be visible since
// (Reach?) tooltips are dismissed on activation.
title={
longName +
' — ' +
Expand Down
Loading